Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add top level Gateway conditions when Routes fail to attach #849

Closed
robscott opened this issue Sep 2, 2021 · 1 comment · Fixed by #859
Closed

Add top level Gateway conditions when Routes fail to attach #849

robscott opened this issue Sep 2, 2021 · 1 comment · Fixed by #859
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@robscott
Copy link
Member

robscott commented Sep 2, 2021

What would you like to be added:
Top level Gateway conditions that can be used to indicate when a Route has not been attached to any listeners within the Gateway.

Why this is needed:
The alternative of adding this condition to each listener is rather unwieldy.

This idea came from a comment thread with @howardjohn and @youngnick.

@robscott robscott added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 2, 2021
@youngnick
Copy link
Contributor

This feels like a separate Condition for sure, that could be effectively treated as a warning, basically saying "a Route tried to attach, but wasn't allowed". I can see an argument both for including (it is useful info that's not otherwise obtainable without querying the implementation somehow), and not including (it could get unwieldy/cause scale problems if there are a lot of Routes).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants