-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better modeling of a "virtual host" #49
Comments
API implementation example for adding tls config in routes: #35 |
/cc @smarterclayton |
@bowei I've started working on this. PTAL at this drawing, which models TLS Config in |
If we give the Developer persona access to a |
xref tls termination policy: #52 |
@danehans That diagram doesn't mention TLS config, so maybe I am missing some context? |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle stale |
#193 addresses some concerns in this issue. |
I think it's a great change ! AllowedHostname[] is reasonable - it allows the domain owner to create a Gateway, set the cert and restrict which namespaces can use the domain. Assuming #197 is addressed ( i.e. allow using the namespace name ) - it seems viable. I'm not very sure the usability of having port 443 and port 80 is great - it is extremely common to have the same hostname on both http and https ( with http doing redirect usually ). In this model, user will have to type every hostname 2x - once for the port 80 and once for port 443. example:
|
Providing hostnames at the gateway layer implies that if you are mixing L4 and L7 listeners, and if there is no way to decide filter hostnames at a per listener level, that would lead to users configuring multiple Gateways. YAML's referencing ( |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Yup, I'm happy yo close this out. |
Closing this since we have consensus on this. If you disagree, please feel free to re-open. |
@hbagdi: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
GKE IAP ingress recipe
This has come up in discussions about the split in functionality between Gateway and the set of Routes attached to a Gateway. See the meeting notes starting here:
The purpose of the split resource is model different permissions and delegation regarding assembly of a LB vs the application author (see "resource model" here: https://kubernetes-sigs.github.io/service-apis/concepts).
As currently sketched, we have virtualhost definitions in the Route while protocol e.g. TLS termination settings are determined in the Gateway. This presents an interesting twist regarding TLS certificates: it is part of a lower-level protocol layer that ties into higher layer HTTPx protocols. Also there are use cases such as support for TLS byte streams or TLS-based opaque routing.
At the same time, we need to be careful about allowing the admin persona control over security related policies, e.g. which certificates can/cannot be attached to a given gateway.
Proposal to get clarity:
The text was updated successfully, but these errors were encountered: