Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define standard PolicyAncestor status type for Policy objects #2923

Open
youngnick opened this issue Apr 2, 2024 · 6 comments
Open

Define standard PolicyAncestor status type for Policy objects #2923

youngnick opened this issue Apr 2, 2024 · 6 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. kind/gep PRs related to Gateway Enhancement Proposal(GEP)

Comments

@youngnick
Copy link
Contributor

Spun out of #2813 (Specifically, #2813 (comment)).

What would you like to be added:

We need either an update to GEP-713, GEP-2648, and GEP-2649 or to make a small GEP under this issue to properly discuss the idea of a PolicyAncestorStatus field, as in BackendTLSPolicy.

The PolicyAncestorStatus field is a status field, based on the ParentStatus in Route objects, that describes its status relative to the named ancestor object. "Ancestor" is used instead of "Parent" (as in Route) because for Policy objects, the relevant object for status is not always going to be the targetRef of the Policy.

Why this is needed:
To further ease the use of the Policy Attachment API pattern.

@youngnick youngnick added kind/feature Categorizes issue or PR as related to a new feature. kind/gep PRs related to Gateway Enhancement Proposal(GEP) labels Apr 2, 2024
@mikemorris
Copy link
Contributor

For additional context, an initial implementation of this pattern was first introduced in #2448

@mikemorris
Copy link
Contributor

mikemorris commented Apr 5, 2024

Finally taking some time to dig deeper into this, and my initial thought is that at a minimum the name for this type feels incorrect (and should instead be PolicyAffectedStatus), because the current name only feels applicable to policies which are targeted at a lower-hierarchy resource which have implications on the behavior of a higher-hierarchy resource, and would not be appropriate for modelling an inverse relationship or peer relationships (such as an AuthorizationPolicy between a Pod/workload and a Service or other Pod/workload).

I understand the utility of this status reporting, but it does feel like a bit of an odd fit for a Direct Policy to communicate an impact on resources other than the policy target (even if no defaults or overrides inheritance needs to be considered). It also feels like there's tension between this approach and the suggestion for Inherited Policies in #2813 for a controller to directly modify the conditions of affected resources by setting a *PolicyAffected condition or label on the affected resource rather than centralized in the Policy status.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 4, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 3, 2024
@mikemorris
Copy link
Contributor

/remove-lifecycle rotten

This is probably duplicative of #738 now, but not sure how to best consolidate.

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Aug 5, 2024
@youngnick
Copy link
Contributor Author

Agreed, let's definitely keep this open to come back to in the 1.13 timeframe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. kind/gep PRs related to Gateway Enhancement Proposal(GEP)
Projects
None yet
Development

No branches or pull requests

4 participants