Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conformance profiles: how to handle multiple "modes" in a project #2233

Closed
Tracked by #1709
howardjohn opened this issue Jul 24, 2023 · 4 comments · Fixed by #2391
Closed
Tracked by #1709

conformance profiles: how to handle multiple "modes" in a project #2233

howardjohn opened this issue Jul 24, 2023 · 4 comments · Fixed by #2391
Assignees
Labels
priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@howardjohn
Copy link
Contributor

Slack context: https://kubernetes.slack.com/archives/CR0H13KGA/p1690238884857489?thread_ts=1690225970.833499&cid=CR0H13KGA

Many projects can operate in different modes. Some examples are Istio in sidecar mode vs ambient, GKE in internal LB mode or external LB mode (or multicluster vs single cluster), etc.

We should prescribe how these are reported in conformance profiles.

@robscott
Copy link
Member

Good question. In GKE behavior is unique per GatewayClass, but other implementations like Istio may have different behavior for the same GatewayClass.

/cc @mlavacca @shaneutt

@mlavacca
Copy link
Member

mlavacca commented Jul 25, 2023

Yeah, it makes total sense. Kong has different modes that actually affect conformance as well. One thing that immediately comes to my mind is adding a new optional field related to the mode in the report's implementation section. I think we need to update the GEP and maybe discuss the implementation details there. @howardjohn would you be interested in tackling that? It'd be great to have someone else coming from other implementations participating in the conformance profiles story.

@shaneutt shaneutt added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jul 25, 2023
@youngnick
Copy link
Contributor

This may be out of scope for this issue, but so it doesn't get lost; should we also consider allowing multiple versions for an implementation?

Copying a comment I put in Slack:

I also thought today about multiple versions - do we want to allow implementations to submit multiple conformance reports, each one for a single version (it seems like it might be nice to be able to say "main is at v1.2.0, stable is at v1.0.0" for an implementation.)
Also, that would allow us to keep history (for example, Cilium 1.14 supports Gateway v0.7.1, but Cilium 1.15 will probably jump straight to Gateway API v1.0.0 because of release cycle timings).

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Aug 14, 2023
@shaneutt shaneutt removed the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Aug 14, 2023
@mlavacca
Copy link
Member

/assign

@shaneutt shaneutt added this to the v1.0.0 milestone Sep 14, 2023
@shaneutt shaneutt removed this from the v1.0.0 milestone Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants