Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate conformance profiles suite flag values #2178

Open
mlavacca opened this issue Jul 11, 2023 · 6 comments
Open

Validate conformance profiles suite flag values #2178

mlavacca opened this issue Jul 11, 2023 · 6 comments
Labels
area/conformance kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@mlavacca
Copy link
Member

mlavacca commented Jul 11, 2023

What would you like to be added:

#2066 added a new CLI to run conformance profiles. This CLI accepts
the following flags related to the implementation running the test suite:

  • organization
  • project
  • url
  • version
  • contact

We need to validate that:

  • url is a valid url
  • version is a valid semver
  • contact contains only valid contacts (@fake_user or fake_user@acme.org)
@mlavacca mlavacca added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 11, 2023
@mlavacca
Copy link
Member Author

/area conformance

@shaneutt shaneutt added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jul 11, 2023
@shaneutt
Copy link
Member

Seems like some good smaller improvements.

/triage accepted

I hesitate to consider it a good-first-issue because it requires someone work on the experimental CLI, and have an implementation they're attaching to conformance, e.t.c. but I do think it's relatively low-hanging fruit for anyone already in that boat.

Not required for GA, but should be worked on not too long after that.

/priority important-longterm

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Jul 21, 2023
@shaneutt shaneutt removed the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jul 21, 2023
@sunjayBhatia
Copy link
Member

I would argue version could maybe be a commit SHA or something similar not necessarily only a semver

@shaneutt
Copy link
Member

I would argue version could maybe be a commit SHA or something similar not necessarily only a semver

That within itself may be a good reason to do a small GEP update only doing that so we can work through it and discuss it.

@tssurya
Copy link

tssurya commented Sep 23, 2023

/cc

@k8s-triage-robot
Copy link

This issue has not been updated in over 1 year, and should be re-triaged.

You can:

  • Confirm that this issue is still relevant with /triage accepted (org members only)
  • Close this issue with /close

For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/

/remove-triage accepted

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. and removed triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/conformance kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Development

No branches or pull requests

6 participants