-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conformance Helpers Should be Cleaned Up #1728
Comments
/area conformance |
I looked at this code a bit yesterday. gateway-api/conformance/utils/kubernetes/helpers.go Lines 404 to 405 in bca1f48
so you still don't know which adapter to use |
actually it is not possible to get a route without providing it's kind before. So you do need to know what type it is upfront. |
one way of doing this without writing code per route type is to use reflection to get RouteStatus, which all routes must have. Seems to work dfc708c |
Neat. I've seen some similar stuff done before using the |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
Yep, this is definitely still useful 👍 |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
What would you like to be added:
We currently have some duplicative methods that really should be unified before we add conformance tests for more types. For example, the following functions have significant overlap:
GatewayAndHTTPRoutesMustBeAccepted + GatewayAndTLSRoutesMustBeAccepted
gateway-api/conformance/utils/kubernetes/helpers.go
Line 231 in bca1f48
gateway-api/conformance/utils/kubernetes/helpers.go
Line 569 in bca1f48
HTTPRouteMustHaveParents + TLSRouteMustHaveParents
gateway-api/conformance/utils/kubernetes/helpers.go
Line 396 in bca1f48
gateway-api/conformance/utils/kubernetes/helpers.go
Line 426 in bca1f48
Why this is needed:
Our conformance tests have grown organically over the years. Although each change made sense in isolation, these changes have resulted in a high likelihood that we'll start to have unexpected variations between tests for different route types.
Note: This is going to be complex to resolve, it would likely be good for someone that already has experience writing and/or running conformance tests to work on this. It may also be good to agree on a direction in this issue before investing too much time in writing code for this.
The text was updated successfully, but these errors were encountered: