Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTPRouteInvalidCrossNamespaceParentRef check for NotAllowedByListeners #1705

Closed
shaneutt opened this issue Feb 7, 2023 · 1 comment · Fixed by #1714
Closed

HTTPRouteInvalidCrossNamespaceParentRef check for NotAllowedByListeners #1705

shaneutt opened this issue Feb 7, 2023 · 1 comment · Fixed by #1714
Assignees
@skriss
Labels
area/conformance good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Milestone
v0.6.2

Comments

@shaneutt
Copy link
Member

shaneutt commented Feb 7, 2023

What would you like to be added:

Noted by @skriss, the HTTPRouteInvalidCrossNamespaceParentRef test should be checking for NotAllowedByListeners.
@shaneutt shaneutt added kind/feature Categorizes issue or PR as related to a new feature. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. area/conformance labels Feb 7, 2023
@shaneutt shaneutt added this to the v0.6.2 milestone Feb 7, 2023
@shaneutt shaneutt mentioned this issue Feb 7, 2023
Merged
@skriss
Copy link
Contributor

skriss commented Feb 8, 2023

I can take this one.

/assign

@skriss skriss mentioned this issue Feb 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skriss skriss

Labels
area/conformance good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
No open projects
Gateway API: The Road to GA
Archived in project
Milestone
v0.6.2
Development

Successfully merging a pull request may close this issue.

conformance: check reason in HTTPRouteInvalidCrossNamespaceParentRef test skriss/gateway-api
2 participants
@skriss @shaneutt