Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GEP 820 - Is it HTTPRouteMatch.ExtensionRef or HTTPRouteFilter.ExtensionRef #1523

Closed
Amila-Rukshan opened this issue Nov 10, 2022 · 2 comments
Closed

GEP 820 - Is it HTTPRouteMatch.ExtensionRef or HTTPRouteFilter.ExtensionRef #1523

Amila-Rukshan opened this issue Nov 10, 2022 · 2 comments
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@Amila-Rukshan
Copy link
Contributor

This GEP 820 says:

Drop extension points within Route match block

but as I checked the reference docs HTTPRouteFilter is the object that support ExtensionRef.

Should it be corrected to HTTPRouteFilter.ExtensionRef or have I understood something wrong?
@Amila-Rukshan Amila-Rukshan added the kind/bug Categorizes issue or PR as related to a bug. label Nov 10, 2022
@Amila-Rukshan Amila-Rukshan mentioned this issue Nov 10, 2022
Closed
@youngnick
Copy link
Contributor

Ah, this GEP is marked as Standard, which means it has been implemented and the extension points have already been removed. So the work is done.

@robscott
Copy link
Member

robscott commented Dec 2, 2022

Sorry for any confusion here, since this work has already been completed, I'm going to close this out.

@robscott robscott closed this as completed Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@robscott @youngnick @Amila-Rukshan