webhook/conformance: Handle incompatible HTTP Filters on a rule

[sunjayBhatia]

Re: The last two bullets in this section of GEP-1364: https://gateway-api.sigs.k8s.io/geps/gep-1364/#accepted

* A HTTPRoute with one rule that specifies a HTTPRequestRedirect filter and a HTTPURLRewrite filter. Accepted must be false,
  because there's only one rule, and this configuration for the rule is invalid (see [reference](https://gateway
  api.sigs.k8s.io/references/spec/#gateway.networking.k8s.io%2fv1beta1.HTTPRequestRedirectFilter)) The error condition in this
  case is undefined currently - we should define it, thanks @sunjayBhatia.

* A HTTPRoute with two rules, one valid and one which specifies a HTTPRequestRedirect filter _and a HTTPURLRewrite filter.
  Accepted is true, because the valid rule can produce some config in the data plane. We'll need to raise the more specific error
  condition for an incompatible filter combination as well to make the partial validity clear.

For incompatible filters in an HTTPRoute, seems like we can do somethings similar to this change that validates HTTP header filters: #1497

We could do this instead of/in addition to the status changes described in the GEP

[robscott]

Thanks @sunjayBhatia! I think we already do that with https://github.com/kubernetes-sigs/gateway-api/blob/main/apis/v1beta1/validation/httproute.go#L127, so maybe we just need a spec update similar to #1497 (comment).

[sunjayBhatia]

oh nice, missed that! i guess only changes needed are these two locations need an update about the Accepted and possible new condition:

• https://gateway-api.sigs.k8s.io/api-types/httproute/#filters-optional
• https://gateway-api.sigs.k8s.io/references/spec/#gateway.networking.k8s.io/v1beta1.HTTPRouteRule (filters field)

[youngnick]

Any chance you can bang out a quick PR to implement that update for us @sunjayBhatia?

I've put this in v0.7.0 so we don't miss it, but if we get the PR done quick, this could make v0.6.0.

[sunjayBhatia]

yep I can try to get this change done soon

[sunjayBhatia]

/assign

[sunjayBhatia]

opened #1540 to address this

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[shaneutt]

/remove-lifecycle stale