Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flags for SupportedFeature and ExemptFeature in conformance tests #1391

Closed
aryan9600 opened this issue Sep 15, 2022 · 2 comments · Fixed by #1394
Closed

Add flags for SupportedFeature and ExemptFeature in conformance tests #1391

aryan9600 opened this issue Sep 15, 2022 · 2 comments · Fixed by #1394
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@aryan9600
Copy link
Member

What would you like to be added:
A flag for configuring SupportedFeature and another for ExemptFeature in the conformance test suite.

Why this is needed:
This would let implementations choose which features they want to include in their conformance test runs, depending on which features are supported/unsupported by them.
@aryan9600 aryan9600 added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 15, 2022
@gyohuangxin
Copy link
Member

gyohuangxin commented Sep 19, 2022 •
edited
Loading

I will work on this.
/assign

@gyohuangxin gyohuangxin mentioned this issue Sep 20, 2022
Merged
@gyohuangxin
Copy link
Member

@aryan9600 I created a PR to add these flags, please feel free to review and leave comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add flags for SupportedFeatures and ExemptFeatures in conformance tests. gyohuangxin/gateway-api
2 participants
@gyohuangxin @aryan9600