Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify RefNotPermitted and InvalidCertificateRef reasons in API Spec #1362

Closed
robscott opened this issue Aug 25, 2022 · 5 comments · Fixed by #1419
Closed

Clarify RefNotPermitted and InvalidCertificateRef reasons in API Spec #1362

robscott opened this issue Aug 25, 2022 · 5 comments · Fixed by #1419
Assignees
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug.
Milestone

Comments

@robscott
Copy link
Member

As a follow up to #1297, @skriss suggested that we should clarify this behavior in the API docs.

  • currently the RefNotPermitted reason only talks about routes and backends - this should be expanded to include listeners and secrets, or maybe remove references to specific resource types altogether
  • we should clarify the scope of InvalidCertificateRef, exactly what an "invalid" certificate ref is, and that it excludes this case of a disallowed cross-namespace reference
@robscott robscott added the kind/bug Categorizes issue or PR as related to a bug. label Aug 25, 2022
@shaneutt shaneutt added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Aug 25, 2022
@mlavacca
Copy link
Member

/assign

@youngnick
Copy link
Contributor

@mlavacca, would you mind holding off on this one until I get some more work done on #1364? I want to make sure that whatever fix we do here is aligned with what we do there.

@mlavacca
Copy link
Member

@youngnick Sure, I'll wait for that one.

@robscott
Copy link
Member Author

@youngnick now that the GEP for #1364 has merged can we unblock this one? I think the work there ended up not requiring any changes to the original plan here, but correct me if I'm wrong.

@youngnick
Copy link
Contributor

Yes, thanks for the poke. This one is unblocked, please go ahead @mlavacca. I'll include any changes you make in my PR to implement #1364, which I'm still working on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants