Skip to content

Commit dda6407

Browse files
authored
fix helm chart support for gke v1alpha2. (#1551)
1 parent bb4fa7c commit dda6407

File tree

4 files changed

+9
-4
lines changed

4 files changed

+9
-4
lines changed

config/charts/inferencepool/README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -131,6 +131,7 @@ The following table list the configurable parameters of the chart.
131131

132132
| **Parameter Name** | **Description** |
133133
|---------------------------------------------|------------------------------------------------------------------------------------------------------------------------|
134+
| `inferencePool.apiVersion` | The API version of the InferencePool resource. Defaults to `inference.networking.k8s.io/v1`. This can be changed to `inference.networking.x-k8s.io/v1alpha2` to support older API versions. |
134135
| `inferencePool.targetPortNumber` | Target port number for the vllm backends, will be used to scrape metrics by the inference extension. Defaults to 8000. |
135136
| `inferencePool.modelServerType` | Type of the model servers in the pool, valid options are [vllm, triton-tensorrt-llm], default is vllm. |
136137
| `inferencePool.modelServers.matchLabels` | Label selector to match vllm backends managed by the inference pool. |

config/charts/inferencepool/templates/epp-deployment.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,10 @@ spec:
2727
- {{ .Release.Name }}
2828
- --pool-namespace
2929
- {{ .Release.Namespace }}
30+
{{- if ne .Values.inferencePool.apiVersion "inference.networking.k8s.io" }}
31+
- --pool-group
32+
- "{{ (split "/" .Values.inferencePool.apiVersion)._0 }}"
33+
{{- end }}
3034
- --zap-encoder
3135
- "json"
3236
- --config-file

config/charts/inferencepool/templates/gke.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ metadata:
99
{{- include "gateway-api-inference-extension.labels" . | nindent 4 }}
1010
spec:
1111
targetRef:
12-
group: "inference.networking.k8s.io"
12+
group: "{{ (split "/" .Values.inferencePool.apiVersion)._0 }}"
1313
kind: InferencePool
1414
name: {{ .Release.Name }}
1515
default:
@@ -28,7 +28,7 @@ metadata:
2828
{{- include "gateway-api-inference-extension.labels" . | nindent 4 }}
2929
spec:
3030
targetRef:
31-
group: "inference.networking.k8s.io"
31+
group: "{{ (split "/" .Values.inferencePool.apiVersion)._0 }}"
3232
kind: InferencePool
3333
name: {{ .Release.Name }}
3434
default:

config/charts/inferencepool/templates/rbac.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,9 @@ metadata:
4040
{{- include "gateway-api-inference-extension.labels" . | nindent 4 }}
4141
rules:
4242
- apiGroups: ["inference.networking.x-k8s.io"]
43-
resources: ["inferenceobjectives", "inferencepools"]
43+
resources: ["inferenceobjectives"]
4444
verbs: ["get", "watch", "list"]
45-
- apiGroups: ["inference.networking.k8s.io"]
45+
- apiGroups: ["{{ (split "/" .Values.inferencePool.apiVersion)._0 }}"]
4646
resources: ["inferencepools"]
4747
verbs: ["get", "watch", "list"]
4848
- apiGroups: [""]

0 commit comments

Comments
 (0)