added back comments on snapshotting pods from datastore before calling schedule

nirrozenbaum · nirrozenbaum · commit 7747fcc2a75b · 2025-06-23T23:23:44.000+03:00
Signed-off-by: Nir Rozenbaum &lt;nirro@il.ibm.com&gt;
diff --git a/pkg/epp/requestcontrol/director.go b/pkg/epp/requestcontrol/director.go
@@ -135,6 +135,9 @@ func (d *Director) HandleRequest(ctx context.Context, reqCtx *handlers.RequestCo
 	}
 
 	// --- 3. Call Scheduler ---
+	// Snapshot pod metrics from the datastore to:
+	// 1. Reduce concurrent access to the datastore.
+	// 2. Ensure consistent data during the scheduling operation of a request between all scheduling cycles.
 	candidatePods := schedulingtypes.ToSchedulerPodMetrics(d.datastore.PodGetAll())
 	results, err := d.scheduler.Schedule(ctx, reqCtx.SchedulingRequest, candidatePods)
 	if err != nil {

Original file line number	Diff line number	Diff line change
`@@ -135,6 +135,9 @@ func (d Director) HandleRequest(ctx context.Context, reqCtx handlers.RequestCo`
`135`	`135`	`}`
`136`	`136`
`137`	`137`	`// --- 3. Call Scheduler ---`
	`138`	`+ // Snapshot pod metrics from the datastore to:`
	`139`	`+ // 1. Reduce concurrent access to the datastore.`
	`140`	`+ // 2. Ensure consistent data during the scheduling operation of a request between all scheduling cycles.`
`138`	`141`	`candidatePods := schedulingtypes.ToSchedulerPodMetrics(d.datastore.PodGetAll())`
`139`	`142`	`results, err := d.scheduler.Schedule(ctx, reqCtx.SchedulingRequest, candidatePods)`
`140`	`143`	`if err != nil {`