🐛 (applyconfiguration): Add year option to generator to ensure consistency behaviour

[camilamacedo86]

Adds optional year parameter to applyconfiguration generator to match behavior of other generators (CRD, webhook, rbac, deepcopy). When specified, replaces " YEAR" placeholder in header file with given year.

More importantly, this creates inconsistency with controller-gen, which causes problems for users.

.PHONY: generate
generate: controller-gen
	"$(CONTROLLER_GEN)" object:headerFile="hack/boilerplate.go.txt",year=$(YEAR) \
	applyconfiguration:headerFile="hack/boilerplate.go.txt" paths="./..."

With this setup, some outputs, such as CRDs, behave differently from others, such as SSA. The result is inconsistent generated files. Be aware that a project can have both scenarios, CRDs with or not SSA annotations.

Then, this should be consistent across all generators. Otherwise, it is confusing for users and is a bug.

Fixes #1371

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: camilamacedo86
Once this PR has been reviewed and has the lgtm label, please assign joelanford for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[camilamacedo86]

@JoelSpeed I think this one is your baby :-)

[k8s-triage-robot]

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-contributor-experience at kubernetes/community.

/check-cla
/easycla

[alvaroaleman]

/hold

For the discussion in #1371

[camilamacedo86]

Hi @alvaroaleman

Thank you for looking on this one.
But it is problematic, I added in the header and in the issue why it is problematic
The problem is in a project we can have both scenarios, with SSA and not then it does not work well.

Consistent behaviour is a key and expected.
So, I do see only 2 options here:

• a) Fix and ensure consistency
• b) No longer support pass the YEAR in any. (but that would be breaking change and besides k8s no longer care about the YEAR anymore, many end users and projects care so I would not go in this direction)

[Vaishnav88sk]

I see this has a do-not-merge/hold on it, is there an open question this is blocked on, or just waiting for review? Happy to take a closer look once the hold is resolved.

[camilamacedo86]

Hi @Vaishnav88sk

I see this has a do-not-merge/hold on it, is there an open question this is blocked on, or just waiting for review? Happy to take a closer look once the hold is resolved.

@alvaroaleman blocked it for discussion: #1379 (review)

As I described in #1379 (comment) IMO it is a bug and must be done or we should not support the YEAR at all.