🌱 Fixups to error when source.Start never returns #3008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/hold
k8s-ci-robot
added
approved
alvaroaleman
commented
Nov 10, 2024
| @@ -220,7 +221,6 @@ func (c *Controller[request]) Start(ctx context.Context) error { | |||
| return err | |||
| } | |||
|
|
|||
| // Start the SharedIndexInformer factories to begin populating the SharedIndexInformer caches | |||
There was a problem hiding this comment.
You mentioned that the comment is in the wrong place and I ended up removing it entirely, as a source doesn't really necessitate a SharedIndexInformer at this point and I found it to be mostly just confusing
Addresses the comments on kubernetes-sigs#2997
alvaroaleman
force-pushed
the
feedback
branch
from
7e67580
to
061a7ad
Compare
|
Thx! /lgtm |
k8s-ci-robot
added
lgtm
|
LGTM label has been added. Git tree hash: 3e40866dfff517af69f32669fce97d335fc35278
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the comments on #2997
/assign @sbueringer
/hold