Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Publish setup-envtest binaries on releases #2911

Merged

Conversation

sbueringer
Copy link
Member

@sbueringer sbueringer commented Aug 7, 2024

Signed-off-by: Stefan Büringer buringerst@vmware.com

This PR adds a GitHub action which will build & upload binaries whenever a tag/release is created
(this requires no changes to our release workflow, simply creating a GitHub release still works)

An example can be seen here: https://github.com/sbueringer/controller-runtime/releases/tag/v0.19.0-beta.0

Signed-off-by: Stefan Büringer buringerst@vmware.com
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 7, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 7, 2024
@sbueringer sbueringer changed the title Publish setup-envtest binaries on releases ✨ Publish setup-envtest binaries on releases Aug 7, 2024
@sbueringer
Copy link
Member Author

/assign @alvaroaleman @vincepri

@sbueringer
Copy link
Member Author

/assign @chrischdi
If you have some time, PTAL as well. This is largely copied from Cluster API (clusterctl)

@sbueringer sbueringer removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2024
@chrischdi
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 8, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 308634e230eff656a415b8f20a89382092955ce0

@sbueringer
Copy link
Member Author

cc @camilamacedo86 (with this it should be easy to just download the setup-envtest binaries instead of building them locally)

@camilamacedo86
Copy link
Member

/lgtm

Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [sbueringer,vincepri]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 12, 2024
@k8s-ci-robot k8s-ci-robot merged commit 7857623 into kubernetes-sigs:main Aug 12, 2024
18 of 20 checks passed
@sbueringer sbueringer deleted the pr-publish-setup-envtest branch August 12, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants