-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Adds WithFieldValidation client #2860
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, lgtm
Putting a hold so others can have a look, too
/hold
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, dlipovetsky The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM label has been added. Git tree hash: 99ddc4de5b300e2bff68e5eb57ae88a950f5e476
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, absolutely in favor! Nice addition
…t options Remove "+optional" tag.
…uests Construct client wrapper using validation as a parameter.
/lgtm |
LGTM label has been added. Git tree hash: 48713d87945e9e50d5b46cd3f58ed31f25ea6799
|
/hold cancel |
This allows our users to enable strict field validation by default for all create, update, and patch requests.
The client can be used in a similar way to the specialized fieldManager-configuring client added in #2771.
Fixes #2859