Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 dependabot: remove go modules bumps, bump all actions at once #2856

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

sbueringer
Copy link
Member

Signed-off-by: Stefan Büringer buringerst@vmware.com

We recently introduce a linter which ensure that our dependencies stay in sync with k/k.
This is important so consumers of CR don't run into compile issues between transitive dependencies of CR & k/k (e.g. if we would use different prometheus versions).

Through this validation we realized that it's basically impossible to bump any dependencies without running out-of-sync in some way with k/k (e.g. even bumping ginkgo leads to a lot of out-of-sync dependencies: #2842 / https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_controller-runtime/2842/pull-controller-runtime-test/1795194368211030016)

This PR:

  • Removes the dependabot config to bump Go modules
  • Optimizes the GitHub action configuration to bump all actions via a single PR (to avoid PR spam)

Signed-off-by: Stefan Büringer buringerst@vmware.com
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 17, 2024
@sbueringer
Copy link
Member Author

/assign @alvaroaleman @vincepri

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 17, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 24, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0c655271c1e7f98c0292e64790d6b1e1b7089adb

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [sbueringer,vincepri]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 162a113 into kubernetes-sigs:main Jun 24, 2024
9 checks passed
@sbueringer sbueringer deleted the pr-dependabot branch June 24, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants