Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-0.16] 🐛 Reintroduce AddMetricsServerExtraHandler on manager #2816

Merged
merged 1 commit into from
May 6, 2024
Merged

[release-0.16] 🐛 Reintroduce AddMetricsServerExtraHandler on manager #2816

merged 1 commit into from
May 6, 2024

Conversation

k8s-infra-cherrypick-robot
Copy link

This is an automated cherry-pick of #2813

/assign vincepri

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request May 6, 2024
Merged
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 6, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 6, 2024
@vincepri
Reintroduce AddMetricsExtraHandler on manager
0bb3250 
Signed-off-by: Vince Prignano <vince@prigna.com>
@vincepri vincepri force-pushed the cherry-pick-2813-to-release-0.16 branch from 2bf6e2a to 0bb3250 Compare May 6, 2024 20:26
@vincepri
Copy link
Member

vincepri commented May 6, 2024

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 6, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b46f8bf90816fa57db5da65c40766982198fdb74

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k8s-infra-cherrypick-robot, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2024
@vincepri
Copy link
Member

vincepri commented May 6, 2024

/retest

1 similar comment
@vincepri
Copy link
Member

vincepri commented May 6, 2024

/retest

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 6, 2024 •
edited
Loading

@k8s-infra-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-controller-runtime-apidiff-release-0-16 0bb3250 link false /test pull-controller-runtime-apidiff-release-0-16

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot merged commit cc6cba0 into kubernetes-sigs:release-0.16 May 6, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FillZpp FillZpp Awaiting requested review from FillZpp

@inteon inteon Awaiting requested review from inteon

Assignees

@vincepri vincepri

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@k8s-infra-cherrypick-robot @vincepri @k8s-ci-robot