🐛 Reintroduce AddMetricsServerExtraHandler on manager #2813
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
|
/cherry-pick release-0.18 |
|
@vincepri: once the present PR merges, I will cherry-pick it on top of release-0.18 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick release-0.17 |
|
@vincepri: once the present PR merges, I will cherry-pick it on top of release-0.17 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick release-0.16 |
|
@vincepri: once the present PR merges, I will cherry-pick it on top of release-0.16 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
vincepri
force-pushed
the
reintroduce-add-extra-metrics-handler
branch
from
b28ea95
to
eece44b
Compare
|
/retest |
1 similar comment
|
/retest |
vincepri
force-pushed
the
reintroduce-add-extra-metrics-handler
branch
3 times, most recently
from
894cb35
to
fac7120
Compare
vincepri
changed the title
Signed-off-by: Vince Prignano <vince@prigna.com>
vincepri
force-pushed
the
reintroduce-add-extra-metrics-handler
branch
from
fac7120
to
610870e
Compare
|
@vincepri: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: 442d71f0ea57fd72a482084d5176ae0a1ea73a2e
|
|
@vincepri: new pull request created: #2815 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@vincepri: new pull request created: #2816 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@vincepri: new pull request created: #2817 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
(Edited by @sbueringer)
Goal of this PR is to reintroduce a means of adding metrics server extra handlers to an existing manager, that was dropped in #2407.
This can be very useful with the "SetupWithManager" pattern, e.g. used in Cluster API (https://github.com/kubernetes-sigs/cluster-api/blob/e23c10dd627125b6d43edf74f059c9e170731446/internal/controllers/cluster/cluster_controller.go#L79). In SetupWithManager funcs the manager is available, but at this point it would be too late to modify the metrics options that have been used to create the manager.