[release-0.17] 🐛 Cache: Fix label defaulting of byObject when namespaces are configured #2807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…igured Currently, if there are global namespaces configured and no per-object namesapces, while there is both a global and a per-object labelSelector, we will: 1. Default the namespaces labelSelector from `DefaultLabelSelector` 2. Copy the namespaces including config into `byObject.Namespaces` And thus end up with the global labelSelector overriding the per-object one, this change fixes that by swapping step 1 and 2.
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
alvaroaleman
approved these changes
May 1, 2024
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: a5895539620479a318f585055348311086e33d99
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, k8s-infra-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
2 tasks
codeboten
referenced
this pull request
in open-telemetry/opentelemetry-collector-contrib
Aug 14, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [sigs.k8s.io/controller-runtime](https://togithub.com/kubernetes-sigs/controller-runtime) | `v0.17.3` -> `v0.18.5` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>kubernetes-sigs/controller-runtime (sigs.k8s.io/controller-runtime)</summary> ### [`v0.18.5`](https://togithub.com/kubernetes-sigs/controller-runtime/releases/tag/v0.18.5) [Compare Source](https://togithub.com/kubernetes-sigs/controller-runtime/compare/v0.18.4...v0.18.5) #### What's Changed - 🐛 Suppress API server warnings in the client by [@​k8s-infra-cherrypick-robot](https://togithub.com/k8s-infra-cherrypick-robot) in [https://github.com/kubernetes-sigs/controller-runtime/pull/2890](https://togithub.com/kubernetes-sigs/controller-runtime/pull/2890) - 🐛 AddMetricsServerExtraHandler: Info takes key/value pairs by [@​k8s-infra-cherrypick-robot](https://togithub.com/k8s-infra-cherrypick-robot) in [https://github.com/kubernetes-sigs/controller-runtime/pull/2917](https://togithub.com/kubernetes-sigs/controller-runtime/pull/2917) - 🐛 Recreate watcher if the file unlinked and replaced by [@​k8s-infra-cherrypick-robot](https://togithub.com/k8s-infra-cherrypick-robot) in [https://github.com/kubernetes-sigs/controller-runtime/pull/2919](https://togithub.com/kubernetes-sigs/controller-runtime/pull/2919) **Full Changelog**: kubernetes-sigs/controller-runtime@v0.18.4...v0.18.5 ### [`v0.18.4`](https://togithub.com/kubernetes-sigs/controller-runtime/releases/tag/v0.18.4) [Compare Source](https://togithub.com/kubernetes-sigs/controller-runtime/compare/v0.18.3...v0.18.4) #### What's Changed - \[release-0.18] ✨ controllerutil: configure BlockOwnerDeletion when setting OwnerReference by [@​k8s-infra-cherrypick-robot](https://togithub.com/k8s-infra-cherrypick-robot) in [https://github.com/kubernetes-sigs/controller-runtime/pull/2848](https://togithub.com/kubernetes-sigs/controller-runtime/pull/2848) **Full Changelog**: kubernetes-sigs/controller-runtime@v0.18.3...v0.18.4 ### [`v0.18.3`](https://togithub.com/kubernetes-sigs/controller-runtime/releases/tag/v0.18.3) [Compare Source](https://togithub.com/kubernetes-sigs/controller-runtime/compare/v0.18.2...v0.18.3) #### What's Changed - ✨ setup-envtest: download binaries from controller-tools releases by [@​sbueringer](https://togithub.com/sbueringer) in [https://github.com/kubernetes-sigs/controller-runtime/pull/2837](https://togithub.com/kubernetes-sigs/controller-runtime/pull/2837) - 🌱 Bump k8s.io/\* to v0.30.1 by [@​sbueringer](https://togithub.com/sbueringer) in [https://github.com/kubernetes-sigs/controller-runtime/pull/2840](https://togithub.com/kubernetes-sigs/controller-runtime/pull/2840) **Full Changelog**: kubernetes-sigs/controller-runtime@v0.18.2...v0.18.3 ### [`v0.18.2`](https://togithub.com/kubernetes-sigs/controller-runtime/releases/tag/v0.18.2) [Compare Source](https://togithub.com/kubernetes-sigs/controller-runtime/compare/v0.18.1...v0.18.2) ##### What's Changed - 🐛 Reintroduce AddMetricsServerExtraHandler on manager by [@​k8s-infra-cherrypick-robot](https://togithub.com/k8s-infra-cherrypick-robot) in [https://github.com/kubernetes-sigs/controller-runtime/pull/2817](https://togithub.com/kubernetes-sigs/controller-runtime/pull/2817) **Full Changelog**: kubernetes-sigs/controller-runtime@v0.18.1...v0.18.2 ### [`v0.18.1`](https://togithub.com/kubernetes-sigs/controller-runtime/releases/tag/v0.18.1) [Compare Source](https://togithub.com/kubernetes-sigs/controller-runtime/compare/v0.18.0...v0.18.1) ##### What's Changed - \[release-0.18] 🐛 Cache: Fix label defaulting of byObject when namespaces are configured by [@​k8s-infra-cherrypick-robot](https://togithub.com/k8s-infra-cherrypick-robot) in [https://github.com/kubernetes-sigs/controller-runtime/pull/2808](https://togithub.com/kubernetes-sigs/controller-runtime/pull/2808) - \[release-0.18] 🐛 correct kind source type by [@​k8s-infra-cherrypick-robot](https://togithub.com/k8s-infra-cherrypick-robot) in [https://github.com/kubernetes-sigs/controller-runtime/pull/2809](https://togithub.com/kubernetes-sigs/controller-runtime/pull/2809) **Full Changelog**: kubernetes-sigs/controller-runtime@v0.18.0...v0.18.1 ### [`v0.18.0`](https://togithub.com/kubernetes-sigs/controller-runtime/releases/tag/v0.18.0) [Compare Source](https://togithub.com/kubernetes-sigs/controller-runtime/compare/v0.17.6...v0.18.0) ####⚠️ Breaking Changes - Bump to k8s.io/\* v1.30 ([#​2693](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2693) [#​2754](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2754) [#​2765](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2765) [#​2776](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2776) [#​2786](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2786)) - Remove deprecated v1alpha1.ControllerManagerConfiguration ([#​2648](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2648)) - admission.Decoder is now an interface ([#​2736](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2736)) - Source, Event, Predicate, Handler: Add generics support ([#​2783](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2783) [#​2796](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2796)) - client: Fix SubResourceCreateOptions signature in subresource client ([#​2766](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2766)) #### ✨ New Features - cache: Add TransformStripManagedFields transform func ([#​2791](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2791)) - client: Add client.WithFieldOwner to configure client-wide FieldManager ([#​2771](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2771) [#​2777](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2777)) - controller: Add `NewQueue` option ([#​2767](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2767)) - manager: Export HTTP server runnable implementation ([#​2473](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2473)) - metrics/server: Add `ListenConfig` option ([#​2519](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2519)) #### 🐛 Bug Fixes - builder/webhook: Return error if For() is used multiple times ([#​2740](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2740)) - cache: Keep selectors when byObject.Namespaces is defaulted ([#​2747](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2747)) - cache: Prevent race when informers are started more than once ([#​2758](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2758)) - fake client: Allow fakeclient to patch CR with no resourceVersion ([#​2725](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2725)) - fake client: Do not consider an apply patch to be a strategic merge patch ([#​2679](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2679)) - manager: Prevent leader election when shutting down a non-elected manager ([#​2724](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2724)) - manager: Runnable group should check if stopped before enqueueing ([#​2757](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2757)) - restmapper: Clean restmapper cache if a version is notFound ([#​2663](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2663)) - restmapper: Fix cache invalidation ([#​2687](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2687)) #### 🌱 Others - ci: Add OSSF scorecard action ([#​2714](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2714)) - ci: Improve github actions dependencies versions and permissions ([#​2715](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2715)) - ci: Pin checkout action in golangci-lint action, bump checkout action, use consistent tag format ([#​2729](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2729)) - ci: Update golangci-lint to v1.57.2 ([#​2708](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2708) [#​2751](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2751)) - ci: Update scorecard github action ([#​2728](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2728)) - ci: Use go-install for versioned dependencies ([#​2710](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2710)) - envtest: WaitForDefaultNamespace while starting up envtest ([#​2668](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2668)) - owners: Cleanup owners files ([#​2730](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2730)) - owners: Remove outdated testing framework approvers ([#​2709](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2709)) - predicate: Compare labels and annotations using maps.Equal ([#​2705](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2705)) - typos: Fix typo of CacheReader comment ([#​2773](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2773)) - typos: Fix typo in channel option ([#​2792](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2792)) - typos: Minor typo fixes in docstrings ([#​2727](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2727)) :book: Additionally, there have been 3 contributions to our documentation and book. ([#​2712](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2712), [#​2770](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2770), [#​2789](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2789)) #### Dependencies ##### Added - github.com/fxamacker/cbor/v2: [v2.6.0](https://togithub.com/fxamacker/cbor/tree/v2.6.0) - github.com/x448/float16: [v0.8.4](https://togithub.com/x448/float16/tree/v0.8.4) - golang.org/x/telemetry: [`b75ee88`](https://togithub.com/kubernetes-sigs/controller-runtime/commit/b75ee88) - k8s.io/gengo/v2: [`51d4e06`](https://togithub.com/kubernetes-sigs/controller-runtime/commit/51d4e06) ##### Changed - github.com/evanphx/json-patch/v5: [v5.8.0 → v5.9.0](https://togithub.com/evanphx/json-patch/compare/v5.8.0...v5.9.0) - github.com/golang/protobuf: [v1.5.3 → v1.5.4](https://togithub.com/golang/protobuf/compare/v1.5.3...v1.5.4) - github.com/google/cel-go: [v0.17.7 → v0.17.8](https://togithub.com/google/cel-go/compare/v0.17.7...v0.17.8) - github.com/onsi/ginkgo/v2: [v2.14.0 → v2.17.1](https://togithub.com/onsi/ginkgo/compare/v2.14.0...v2.17.1) - github.com/onsi/gomega: [v1.30.0 → v1.32.0](https://togithub.com/onsi/gomega/compare/v1.30.0...v1.32.0) - github.com/prometheus/client_golang: [v1.18.0 → v1.16.0](https://togithub.com/prometheus/client_golang/compare/v1.18.0...v1.16.0) - github.com/prometheus/client_model: [v0.5.0 → v0.4.0](https://togithub.com/prometheus/client_model/compare/v0.5.0...v0.4.0) - github.com/prometheus/common: [v0.45.0 → v0.44.0](https://togithub.com/prometheus/common/compare/v0.45.0...v0.44.0) - golang.org/x/crypto: v0.16.0 → v0.21.0 - golang.org/x/mod: v0.14.0 → v0.15.0 - golang.org/x/net: v0.19.0 → v0.23.0 - golang.org/x/sync: v0.5.0 → v0.6.0 - golang.org/x/sys: v0.16.0 → v0.18.0 - golang.org/x/term: v0.15.0 → v0.18.0 - golang.org/x/tools: v0.16.1 → v0.18.0 - google.golang.org/protobuf: v1.31.0 → v1.33.0 - k8s.io/api: v0.29.0 → v0.30.0 - k8s.io/apiextensions-apiserver: v0.29.0 → v0.30.0 - k8s.io/apimachinery: v0.29.0 → v0.30.0 - k8s.io/apiserver: v0.29.0 → v0.30.0 - k8s.io/client-go: v0.29.0 → v0.30.0 - k8s.io/code-generator: v0.29.0 → v0.30.0 - k8s.io/component-base: v0.29.0 → v0.30.0 - k8s.io/klog/v2: v2.110.1 → v2.120.1 - k8s.io/kms: v0.29.0 → v0.30.0 - k8s.io/kube-openapi: [`2dd684a`](https://togithub.com/kubernetes-sigs/controller-runtime/commit/2dd684a) → [`70dd376`](https://togithub.com/kubernetes-sigs/controller-runtime/commit/70dd376) - sigs.k8s.io/apiserver-network-proxy/konnectivity-client: v0.28.0 → v0.29.0 - sigs.k8s.io/yaml: v1.4.0 → v1.3.0 ##### Removed - github.com/matttproud/golang_protobuf_extensions/v2: [v2.0.0](https://togithub.com/matttproud/golang_protobuf_extensions/tree/v2.0.0) - go.uber.org/atomic: v1.10.0 - k8s.io/gengo: [`9cce18d`](https://togithub.com/kubernetes-sigs/controller-runtime/commit/9cce18d) *Thanks to all our contributors!* 😊 ### [`v0.17.6`](https://togithub.com/kubernetes-sigs/controller-runtime/releases/tag/v0.17.6) [Compare Source](https://togithub.com/kubernetes-sigs/controller-runtime/compare/v0.17.5...v0.17.6) #### What's Changed - ✨ setup-envtest: download binaries from controller-tools releases by [@​damdo](https://togithub.com/damdo) in [https://github.com/kubernetes-sigs/controller-runtime/pull/2843](https://togithub.com/kubernetes-sigs/controller-runtime/pull/2843) - 🐛 Recreate watcher if the file unlinked and replaced by [@​k8s-infra-cherrypick-robot](https://togithub.com/k8s-infra-cherrypick-robot) in [https://github.com/kubernetes-sigs/controller-runtime/pull/2920](https://togithub.com/kubernetes-sigs/controller-runtime/pull/2920) **Full Changelog**: kubernetes-sigs/controller-runtime@v0.17.5...v0.17.6 ### [`v0.17.5`](https://togithub.com/kubernetes-sigs/controller-runtime/releases/tag/v0.17.5) [Compare Source](https://togithub.com/kubernetes-sigs/controller-runtime/compare/v0.17.4...v0.17.5) #### What's Changed - 🐛 Reintroduce AddMetricsServerExtraHandler on manager by [@​k8s-infra-cherrypick-robot](https://togithub.com/k8s-infra-cherrypick-robot) in [https://github.com/kubernetes-sigs/controller-runtime/pull/2815](https://togithub.com/kubernetes-sigs/controller-runtime/pull/2815) **Full Changelog**: kubernetes-sigs/controller-runtime@v0.17.4...v0.17.5 ### [`v0.17.4`](https://togithub.com/kubernetes-sigs/controller-runtime/releases/tag/v0.17.4) [Compare Source](https://togithub.com/kubernetes-sigs/controller-runtime/compare/v0.17.3...v0.17.4) #### What's Changed - \[release-0.17] ✨ client: Add client-wide fieldManager by [@​k8s-infra-cherrypick-robot](https://togithub.com/k8s-infra-cherrypick-robot) in [https://github.com/kubernetes-sigs/controller-runtime/pull/2772](https://togithub.com/kubernetes-sigs/controller-runtime/pull/2772) - \[release-0.17] 🐛 Cache: Fix label defaulting of byObject when namespaces are configured by [@​k8s-infra-cherrypick-robot](https://togithub.com/k8s-infra-cherrypick-robot) in [https://github.com/kubernetes-sigs/controller-runtime/pull/2807](https://togithub.com/kubernetes-sigs/controller-runtime/pull/2807) **Full Changelog**: kubernetes-sigs/controller-runtime@v0.17.3...v0.17.4 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguMjYuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIiwicmVub3ZhdGVib3QiXX0=--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com> Co-authored-by: Yang Song <songy23@users.noreply.github.com>
f7o
referenced
this pull request
in f7o/opentelemetry-collector-contrib
Sep 12, 2024
](https://renovatebot.com){kind=link}
…ry#34668) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [sigs.k8s.io/controller-runtime](https://togithub.com/kubernetes-sigs/controller-runtime) | `v0.17.3` -> `v0.18.5` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>kubernetes-sigs/controller-runtime (sigs.k8s.io/controller-runtime)</summary> ### [`v0.18.5`](https://togithub.com/kubernetes-sigs/controller-runtime/releases/tag/v0.18.5) [Compare Source](https://togithub.com/kubernetes-sigs/controller-runtime/compare/v0.18.4...v0.18.5) #### What's Changed - 🐛 Suppress API server warnings in the client by [@&open-telemetry#8203;k8s-infra-cherrypick-robot](https://togithub.com/k8s-infra-cherrypick-robot) in [https://github.com/kubernetes-sigs/controller-runtime/pull/2890](https://togithub.com/kubernetes-sigs/controller-runtime/pull/2890) - 🐛 AddMetricsServerExtraHandler: Info takes key/value pairs by [@&open-telemetry#8203;k8s-infra-cherrypick-robot](https://togithub.com/k8s-infra-cherrypick-robot) in [https://github.com/kubernetes-sigs/controller-runtime/pull/2917](https://togithub.com/kubernetes-sigs/controller-runtime/pull/2917) - 🐛 Recreate watcher if the file unlinked and replaced by [@&open-telemetry#8203;k8s-infra-cherrypick-robot](https://togithub.com/k8s-infra-cherrypick-robot) in [https://github.com/kubernetes-sigs/controller-runtime/pull/2919](https://togithub.com/kubernetes-sigs/controller-runtime/pull/2919) **Full Changelog**: kubernetes-sigs/controller-runtime@v0.18.4...v0.18.5 ### [`v0.18.4`](https://togithub.com/kubernetes-sigs/controller-runtime/releases/tag/v0.18.4) [Compare Source](https://togithub.com/kubernetes-sigs/controller-runtime/compare/v0.18.3...v0.18.4) #### What's Changed - \[release-0.18] ✨ controllerutil: configure BlockOwnerDeletion when setting OwnerReference by [@&open-telemetry#8203;k8s-infra-cherrypick-robot](https://togithub.com/k8s-infra-cherrypick-robot) in [https://github.com/kubernetes-sigs/controller-runtime/pull/2848](https://togithub.com/kubernetes-sigs/controller-runtime/pull/2848) **Full Changelog**: kubernetes-sigs/controller-runtime@v0.18.3...v0.18.4 ### [`v0.18.3`](https://togithub.com/kubernetes-sigs/controller-runtime/releases/tag/v0.18.3) [Compare Source](https://togithub.com/kubernetes-sigs/controller-runtime/compare/v0.18.2...v0.18.3) #### What's Changed - ✨ setup-envtest: download binaries from controller-tools releases by [@&open-telemetry#8203;sbueringer](https://togithub.com/sbueringer) in [https://github.com/kubernetes-sigs/controller-runtime/pull/2837](https://togithub.com/kubernetes-sigs/controller-runtime/pull/2837) - 🌱 Bump k8s.io/\* to v0.30.1 by [@&open-telemetry#8203;sbueringer](https://togithub.com/sbueringer) in [https://github.com/kubernetes-sigs/controller-runtime/pull/2840](https://togithub.com/kubernetes-sigs/controller-runtime/pull/2840) **Full Changelog**: kubernetes-sigs/controller-runtime@v0.18.2...v0.18.3 ### [`v0.18.2`](https://togithub.com/kubernetes-sigs/controller-runtime/releases/tag/v0.18.2) [Compare Source](https://togithub.com/kubernetes-sigs/controller-runtime/compare/v0.18.1...v0.18.2) ##### What's Changed - 🐛 Reintroduce AddMetricsServerExtraHandler on manager by [@&open-telemetry#8203;k8s-infra-cherrypick-robot](https://togithub.com/k8s-infra-cherrypick-robot) in [https://github.com/kubernetes-sigs/controller-runtime/pull/2817](https://togithub.com/kubernetes-sigs/controller-runtime/pull/2817) **Full Changelog**: kubernetes-sigs/controller-runtime@v0.18.1...v0.18.2 ### [`v0.18.1`](https://togithub.com/kubernetes-sigs/controller-runtime/releases/tag/v0.18.1) [Compare Source](https://togithub.com/kubernetes-sigs/controller-runtime/compare/v0.18.0...v0.18.1) ##### What's Changed - \[release-0.18] 🐛 Cache: Fix label defaulting of byObject when namespaces are configured by [@&open-telemetry#8203;k8s-infra-cherrypick-robot](https://togithub.com/k8s-infra-cherrypick-robot) in [https://github.com/kubernetes-sigs/controller-runtime/pull/2808](https://togithub.com/kubernetes-sigs/controller-runtime/pull/2808) - \[release-0.18] 🐛 correct kind source type by [@&open-telemetry#8203;k8s-infra-cherrypick-robot](https://togithub.com/k8s-infra-cherrypick-robot) in [https://github.com/kubernetes-sigs/controller-runtime/pull/2809](https://togithub.com/kubernetes-sigs/controller-runtime/pull/2809) **Full Changelog**: kubernetes-sigs/controller-runtime@v0.18.0...v0.18.1 ### [`v0.18.0`](https://togithub.com/kubernetes-sigs/controller-runtime/releases/tag/v0.18.0) [Compare Source](https://togithub.com/kubernetes-sigs/controller-runtime/compare/v0.17.6...v0.18.0) ####⚠️ Breaking Changes - Bump to k8s.io/\* v1.30 ([#&open-telemetry#8203;2693](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2693) [#&open-telemetry#8203;2754](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2754) [#&open-telemetry#8203;2765](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2765) [#&open-telemetry#8203;2776](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2776) [#&open-telemetry#8203;2786](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2786)) - Remove deprecated v1alpha1.ControllerManagerConfiguration ([#&open-telemetry#8203;2648](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2648)) - admission.Decoder is now an interface ([#&open-telemetry#8203;2736](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2736)) - Source, Event, Predicate, Handler: Add generics support ([#&open-telemetry#8203;2783](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2783) [#&open-telemetry#8203;2796](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2796)) - client: Fix SubResourceCreateOptions signature in subresource client ([#&open-telemetry#8203;2766](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2766)) #### ✨ New Features - cache: Add TransformStripManagedFields transform func ([#&open-telemetry#8203;2791](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2791)) - client: Add client.WithFieldOwner to configure client-wide FieldManager ([#&open-telemetry#8203;2771](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2771) [#&open-telemetry#8203;2777](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2777)) - controller: Add `NewQueue` option ([#&open-telemetry#8203;2767](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2767)) - manager: Export HTTP server runnable implementation ([#&open-telemetry#8203;2473](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2473)) - metrics/server: Add `ListenConfig` option ([#&open-telemetry#8203;2519](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2519)) #### 🐛 Bug Fixes - builder/webhook: Return error if For() is used multiple times ([#&open-telemetry#8203;2740](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2740)) - cache: Keep selectors when byObject.Namespaces is defaulted ([#&open-telemetry#8203;2747](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2747)) - cache: Prevent race when informers are started more than once ([#&open-telemetry#8203;2758](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2758)) - fake client: Allow fakeclient to patch CR with no resourceVersion ([#&open-telemetry#8203;2725](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2725)) - fake client: Do not consider an apply patch to be a strategic merge patch ([#&open-telemetry#8203;2679](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2679)) - manager: Prevent leader election when shutting down a non-elected manager ([#&open-telemetry#8203;2724](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2724)) - manager: Runnable group should check if stopped before enqueueing ([#&open-telemetry#8203;2757](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2757)) - restmapper: Clean restmapper cache if a version is notFound ([#&open-telemetry#8203;2663](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2663)) - restmapper: Fix cache invalidation ([#&open-telemetry#8203;2687](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2687)) #### 🌱 Others - ci: Add OSSF scorecard action ([#&open-telemetry#8203;2714](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2714)) - ci: Improve github actions dependencies versions and permissions ([#&open-telemetry#8203;2715](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2715)) - ci: Pin checkout action in golangci-lint action, bump checkout action, use consistent tag format ([#&open-telemetry#8203;2729](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2729)) - ci: Update golangci-lint to v1.57.2 ([#&open-telemetry#8203;2708](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2708) [#&open-telemetry#8203;2751](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2751)) - ci: Update scorecard github action ([#&open-telemetry#8203;2728](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2728)) - ci: Use go-install for versioned dependencies ([#&open-telemetry#8203;2710](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2710)) - envtest: WaitForDefaultNamespace while starting up envtest ([#&open-telemetry#8203;2668](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2668)) - owners: Cleanup owners files ([#&open-telemetry#8203;2730](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2730)) - owners: Remove outdated testing framework approvers ([#&open-telemetry#8203;2709](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2709)) - predicate: Compare labels and annotations using maps.Equal ([#&open-telemetry#8203;2705](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2705)) - typos: Fix typo of CacheReader comment ([#&open-telemetry#8203;2773](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2773)) - typos: Fix typo in channel option ([#&open-telemetry#8203;2792](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2792)) - typos: Minor typo fixes in docstrings ([#&open-telemetry#8203;2727](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2727)) :book: Additionally, there have been 3 contributions to our documentation and book. ([#&open-telemetry#8203;2712](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2712), [#&open-telemetry#8203;2770](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2770), [#&open-telemetry#8203;2789](https://togithub.com/kubernetes-sigs/controller-runtime/issues/2789)) #### Dependencies ##### Added - github.com/fxamacker/cbor/v2: [v2.6.0](https://togithub.com/fxamacker/cbor/tree/v2.6.0) - github.com/x448/float16: [v0.8.4](https://togithub.com/x448/float16/tree/v0.8.4) - golang.org/x/telemetry: [`b75ee88`](https://togithub.com/kubernetes-sigs/controller-runtime/commit/b75ee88) - k8s.io/gengo/v2: [`51d4e06`](https://togithub.com/kubernetes-sigs/controller-runtime/commit/51d4e06) ##### Changed - github.com/evanphx/json-patch/v5: [v5.8.0 → v5.9.0](https://togithub.com/evanphx/json-patch/compare/v5.8.0...v5.9.0) - github.com/golang/protobuf: [v1.5.3 → v1.5.4](https://togithub.com/golang/protobuf/compare/v1.5.3...v1.5.4) - github.com/google/cel-go: [v0.17.7 → v0.17.8](https://togithub.com/google/cel-go/compare/v0.17.7...v0.17.8) - github.com/onsi/ginkgo/v2: [v2.14.0 → v2.17.1](https://togithub.com/onsi/ginkgo/compare/v2.14.0...v2.17.1) - github.com/onsi/gomega: [v1.30.0 → v1.32.0](https://togithub.com/onsi/gomega/compare/v1.30.0...v1.32.0) - github.com/prometheus/client_golang: [v1.18.0 → v1.16.0](https://togithub.com/prometheus/client_golang/compare/v1.18.0...v1.16.0) - github.com/prometheus/client_model: [v0.5.0 → v0.4.0](https://togithub.com/prometheus/client_model/compare/v0.5.0...v0.4.0) - github.com/prometheus/common: [v0.45.0 → v0.44.0](https://togithub.com/prometheus/common/compare/v0.45.0...v0.44.0) - golang.org/x/crypto: v0.16.0 → v0.21.0 - golang.org/x/mod: v0.14.0 → v0.15.0 - golang.org/x/net: v0.19.0 → v0.23.0 - golang.org/x/sync: v0.5.0 → v0.6.0 - golang.org/x/sys: v0.16.0 → v0.18.0 - golang.org/x/term: v0.15.0 → v0.18.0 - golang.org/x/tools: v0.16.1 → v0.18.0 - google.golang.org/protobuf: v1.31.0 → v1.33.0 - k8s.io/api: v0.29.0 → v0.30.0 - k8s.io/apiextensions-apiserver: v0.29.0 → v0.30.0 - k8s.io/apimachinery: v0.29.0 → v0.30.0 - k8s.io/apiserver: v0.29.0 → v0.30.0 - k8s.io/client-go: v0.29.0 → v0.30.0 - k8s.io/code-generator: v0.29.0 → v0.30.0 - k8s.io/component-base: v0.29.0 → v0.30.0 - k8s.io/klog/v2: v2.110.1 → v2.120.1 - k8s.io/kms: v0.29.0 → v0.30.0 - k8s.io/kube-openapi: [`2dd684a`](https://togithub.com/kubernetes-sigs/controller-runtime/commit/2dd684a) → [`70dd376`](https://togithub.com/kubernetes-sigs/controller-runtime/commit/70dd376) - sigs.k8s.io/apiserver-network-proxy/konnectivity-client: v0.28.0 → v0.29.0 - sigs.k8s.io/yaml: v1.4.0 → v1.3.0 ##### Removed - github.com/matttproud/golang_protobuf_extensions/v2: [v2.0.0](https://togithub.com/matttproud/golang_protobuf_extensions/tree/v2.0.0) - go.uber.org/atomic: v1.10.0 - k8s.io/gengo: [`9cce18d`](https://togithub.com/kubernetes-sigs/controller-runtime/commit/9cce18d) *Thanks to all our contributors!* 😊 ### [`v0.17.6`](https://togithub.com/kubernetes-sigs/controller-runtime/releases/tag/v0.17.6) [Compare Source](https://togithub.com/kubernetes-sigs/controller-runtime/compare/v0.17.5...v0.17.6) #### What's Changed - ✨ setup-envtest: download binaries from controller-tools releases by [@&open-telemetry#8203;damdo](https://togithub.com/damdo) in [https://github.com/kubernetes-sigs/controller-runtime/pull/2843](https://togithub.com/kubernetes-sigs/controller-runtime/pull/2843) - 🐛 Recreate watcher if the file unlinked and replaced by [@&open-telemetry#8203;k8s-infra-cherrypick-robot](https://togithub.com/k8s-infra-cherrypick-robot) in [https://github.com/kubernetes-sigs/controller-runtime/pull/2920](https://togithub.com/kubernetes-sigs/controller-runtime/pull/2920) **Full Changelog**: kubernetes-sigs/controller-runtime@v0.17.5...v0.17.6 ### [`v0.17.5`](https://togithub.com/kubernetes-sigs/controller-runtime/releases/tag/v0.17.5) [Compare Source](https://togithub.com/kubernetes-sigs/controller-runtime/compare/v0.17.4...v0.17.5) #### What's Changed - 🐛 Reintroduce AddMetricsServerExtraHandler on manager by [@&open-telemetry#8203;k8s-infra-cherrypick-robot](https://togithub.com/k8s-infra-cherrypick-robot) in [https://github.com/kubernetes-sigs/controller-runtime/pull/2815](https://togithub.com/kubernetes-sigs/controller-runtime/pull/2815) **Full Changelog**: kubernetes-sigs/controller-runtime@v0.17.4...v0.17.5 ### [`v0.17.4`](https://togithub.com/kubernetes-sigs/controller-runtime/releases/tag/v0.17.4) [Compare Source](https://togithub.com/kubernetes-sigs/controller-runtime/compare/v0.17.3...v0.17.4) #### What's Changed - \[release-0.17] ✨ client: Add client-wide fieldManager by [@&open-telemetry#8203;k8s-infra-cherrypick-robot](https://togithub.com/k8s-infra-cherrypick-robot) in [https://github.com/kubernetes-sigs/controller-runtime/pull/2772](https://togithub.com/kubernetes-sigs/controller-runtime/pull/2772) - \[release-0.17] 🐛 Cache: Fix label defaulting of byObject when namespaces are configured by [@&open-telemetry#8203;k8s-infra-cherrypick-robot](https://togithub.com/k8s-infra-cherrypick-robot) in [https://github.com/kubernetes-sigs/controller-runtime/pull/2807](https://togithub.com/kubernetes-sigs/controller-runtime/pull/2807) **Full Changelog**: kubernetes-sigs/controller-runtime@v0.17.3...v0.17.4 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguMjYuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIiwicmVub3ZhdGVib3QiXX0=--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com> Co-authored-by: Yang Song <songy23@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #2805
/assign alvaroaleman