-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 correct kind source type #2806
🐛 correct kind source type #2806
Conversation
Reverse the nil check in the String function of the internal Kind source to print the type when known. Fixes: 2add01e ("Event, source, handler, predicates: Use generics") Signed-off-by: Terin Stock <terinjokes@gmail.com>
Hi @terinjokes. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc alvaroaleman |
LGTM label has been added. Git tree hash: c78274afb2176a86fdf2f9055d171e17f726768a
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, terinjokes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test Thank you! |
/cherrpick release-0.18 |
/cherrypick release-0.18 |
@alvaroaleman: new pull request created: #2809 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Reverse the nil check in the String function of the internal Kind source to print the type when known.
Fixes: 2add01e ("Event, source, handler, predicates: Use generics")