🐛 Cache: Fix label defaulting of byObject when namespaces are configured #2805
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
Currently, if there are global namespaces configured and no per-object namesapces, while there is both a global and a per-object labelSelector, we will: 1. Default the namespaces labelSelector from `DefaultLabelSelector` 2. Copy the namespaces including config into `byObject.Namespaces` And thus end up with the global labelSelector overriding the per-object one, this change fixes that by swapping step 1 and 2.
|
/cherrypick release-0.17 |
|
@alvaroaleman: once the present PR merges, I will cherry-pick it on top of release-0.17 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick release-0.18 |
|
@alvaroaleman: once the present PR merges, I will cherry-pick it on top of release-0.18 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: 1e782c1e6f0742c2788bfa2c7303d6fb0fdabac7
|
|
@alvaroaleman: new pull request created: #2807 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@alvaroaleman: new pull request created: #2808 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Currently, if there are global namespaces configured and no per-object namesapces, while there is both a global and a per-object labelSelector, we will:
DefaultLabelSelectorbyObject.NamespacesAnd thus end up with the global labelSelector overriding the per-object one, this change fixes that by swapping step 1 and 2.
Fixes #2804