🌱 Bump to k/k 1.30 RC2, downgrade prometheus, zap, golang.org/x/sys, sigs.k8s.io/yaml #2776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
size/M
|
I'll take a look at the finding in a bit |
vincepri
reviewed
Apr 15, 2024
to k/k versions Signed-off-by: Stefan Büringer buringerst@vmware.com
sbueringer
force-pushed
the
pr-downgrade
branch
from
8049f75
to
75523c9
Compare
k8s-ci-robot
added
size/L
sbueringer
changed the title
|
@vincepri PTAL |
vincepri
approved these changes
Apr 15, 2024
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 1257c094b5003c69baf977fb0ec3dcd99062d98c
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to k/k versions
Signed-off-by: Stefan Büringer buringerst@vmware.com
Context: we had some problems with compile issues with prometheus/client_.* caused by diverging versions between CR & k/k
#2774 will introduce a tool that ensure the dependencies are always sync. The current PR downgrades the dependencies that are currently out of sync.