-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Create RemoveOwnerReference
function in controllerutil to remove owner references from objects
#2462
🌱 Create RemoveOwnerReference
function in controllerutil to remove owner references from objects
#2462
Conversation
Hi @troy0820. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
RemoveOwnerReference
function in controllerutilRemoveOwnerReference
function in controllerutil to remove owner references from objects
RemoveOwnerReference
function in controllerutil to remove owner references from objectsRemoveOwnerReference
function in controllerutil to remove owner references from objects
1149aa0
to
36ecb53
Compare
lgtm pending the linter findings |
36ecb53
to
bb50662
Compare
Signed-off-by: Troy Connor <troy0820@users.noreply.github.com>
bb50662
to
1eb9a0c
Compare
Thank you! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer, troy0820 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
When using the function SetControllerReference it will error when trying to overwrite the controller reference. In issue #2381 the method used to circumvent the errors is to remove the controller reference and then reapply the new controller reference. There is no exposed method to do this. This mimics the behavior of removing a finalizer
Creating this function allows a user to remove the owner reference of an object.
Also helps with #2381