Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Create RemoveOwnerReference function in controllerutil to remove owner references from objects #2462

Conversation

troy0820
Copy link
Member

@troy0820 troy0820 commented Aug 30, 2023

When using the function SetControllerReference it will error when trying to overwrite the controller reference. In issue #2381 the method used to circumvent the errors is to remove the controller reference and then reapply the new controller reference. There is no exposed method to do this. This mimics the behavior of removing a finalizer

Creating this function allows a user to remove the owner reference of an object.
Also helps with #2381

  • Create function that removes owner reference from object (similar to remove finalizer)
  • Create unit test for function
Add function RemoveOwnerReference to pkg/controller/controllerutil 
to allow the removal of the owner reference of the controlled object.```

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 30, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @troy0820. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 30, 2023
@troy0820 troy0820 changed the title 🐛Create RemoveOwnerReference function in controllerutil 🐛Create RemoveOwnerReference function in controllerutil to remove owner references from objects Aug 30, 2023
@troy0820 troy0820 changed the title 🐛Create RemoveOwnerReference function in controllerutil to remove owner references from objects 🌱 Create RemoveOwnerReference function in controllerutil to remove owner references from objects Sep 9, 2023
@troy0820 troy0820 force-pushed the troy0820/add-remove-owner-reference-function branch 2 times, most recently from 1149aa0 to 36ecb53 Compare September 12, 2023 17:32
@sbueringer
Copy link
Member

lgtm pending the linter findings

@troy0820 troy0820 force-pushed the troy0820/add-remove-owner-reference-function branch from 36ecb53 to bb50662 Compare September 12, 2023 17:37
Signed-off-by: Troy Connor <troy0820@users.noreply.github.com>
@troy0820 troy0820 force-pushed the troy0820/add-remove-owner-reference-function branch from bb50662 to 1eb9a0c Compare September 12, 2023 17:45
@sbueringer
Copy link
Member

Thank you!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 12, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer, troy0820

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 12, 2023
@k8s-ci-robot k8s-ci-robot merged commit 8117577 into kubernetes-sigs:main Sep 12, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants