⚠ Introduce and use client.Object and client.ObjectList #1195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
coderanger
reviewed
Oct 1, 2020
|
/assign @alvaroaleman @DirectXMan12 |
vincepri
commented
Oct 1, 2020
vincepri
force-pushed
the
reconcile-object
branch
2 times, most recently
from
004b290 to
af35a4f
Compare
alvaroaleman
approved these changes
Oct 1, 2020
k8s-ci-robot
added
do-not-merge/hold
DirectXMan12
suggested changes
Oct 1, 2020
This change introduces two interfaces: client.Object and client.ObjectList. These interfaces are now used throughout the codebase, more specifically in the client. Signed-off-by: Vince Prignano <vincepri@vmware.com>
vincepri
force-pushed
the
reconcile-object
branch
from
af35a4f to
00af7b6
Compare
k8s-ci-robot
removed
the
lgtm
DirectXMan12
approved these changes
Oct 1, 2020
alvaroaleman
reviewed
Oct 1, 2020
|
(this is gonna fail to compile, doing a quick push to test something with the new PR verifier) |
|
/retest |
|
@vincepri: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
ChunyiLyu
added a commit
to rabbitmq/cluster-operator
that referenced
this pull request
Jan 6, 2021
Bump controller-runtime to 0.7 and k8s.io dependencies to v.0.19.2 * Update leader election role to have permission for leases.coordination.k8s.io instead of ConfigMap. Related controller runtime change: kubernetes-sigs/controller-runtime#1144 * Use client.Object instead of runtime.Object in controller runtime helper methods. A number of controller runtime methods that previously took runtime.Object & internally type-asserted them to metav1.Object now take client.Object and client.ObjectList. Related controller runtime change: kubernetes-sigs/controller-runtime#1195 * Update how envTest starts the test manager since Manager.Start() now takes context instead of a channel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces two interfaces: client.Object and
client.ObjectList.
These interfaces are now used throughout the codebase, more specifically
in the client.
Signed-off-by: Vince Prignano vincepri@vmware.com
/milestone v0.7.x