Skip to content

Commit

Permalink
chore: still using zap.New as the default logger bootstrapper
Browse files Browse the repository at this point in the history
Signed-off-by: STRRL <im@strrl.dev>
  • Loading branch information
STRRL committed Jul 17, 2022
1 parent 934ef05 commit 521d348
Show file tree
Hide file tree
Showing 17 changed files with 38 additions and 384 deletions.
4 changes: 2 additions & 2 deletions examples/builtins/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,15 +26,15 @@ import (
"sigs.k8s.io/controller-runtime/pkg/controller"
"sigs.k8s.io/controller-runtime/pkg/handler"
"sigs.k8s.io/controller-runtime/pkg/log"
"sigs.k8s.io/controller-runtime/pkg/log/bootstrap"
"sigs.k8s.io/controller-runtime/pkg/log/zap"
"sigs.k8s.io/controller-runtime/pkg/manager"
"sigs.k8s.io/controller-runtime/pkg/manager/signals"
"sigs.k8s.io/controller-runtime/pkg/source"
"sigs.k8s.io/controller-runtime/pkg/webhook"
)

func init() {
log.SetLogger(bootstrap.New())
log.SetLogger(zap.New())
}

func main() {
Expand Down
4 changes: 2 additions & 2 deletions examples/configfile/builtin/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -28,14 +28,14 @@ import (
"sigs.k8s.io/controller-runtime/pkg/client/config"
cfg "sigs.k8s.io/controller-runtime/pkg/config"
"sigs.k8s.io/controller-runtime/pkg/log"
"sigs.k8s.io/controller-runtime/pkg/log/bootstrap"
"sigs.k8s.io/controller-runtime/pkg/log/zap"
"sigs.k8s.io/controller-runtime/pkg/manager/signals"
)

var scheme = runtime.NewScheme()

func init() {
log.SetLogger(bootstrap.New())
log.SetLogger(zap.New())
clientgoscheme.AddToScheme(scheme)
}

Expand Down
4 changes: 2 additions & 2 deletions examples/configfile/custom/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -29,14 +29,14 @@ import (
"sigs.k8s.io/controller-runtime/pkg/client/config"
cfg "sigs.k8s.io/controller-runtime/pkg/config"
"sigs.k8s.io/controller-runtime/pkg/log"
"sigs.k8s.io/controller-runtime/pkg/log/bootstrap"
"sigs.k8s.io/controller-runtime/pkg/log/zap"
"sigs.k8s.io/controller-runtime/pkg/manager/signals"
)

var scheme = runtime.NewScheme()

func init() {
log.SetLogger(bootstrap.New())
log.SetLogger(zap.New())
clientgoscheme.AddToScheme(scheme)
v1alpha1.AddToScheme(scheme)
}
Expand Down
4 changes: 2 additions & 2 deletions examples/crd/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ import (
api "sigs.k8s.io/controller-runtime/examples/crd/pkg"
"sigs.k8s.io/controller-runtime/pkg/client"
"sigs.k8s.io/controller-runtime/pkg/log"
"sigs.k8s.io/controller-runtime/pkg/log/bootstrap"
"sigs.k8s.io/controller-runtime/pkg/log/zap"
)

var (
Expand Down Expand Up @@ -102,7 +102,7 @@ func (r *reconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Resu
}

func main() {
ctrl.SetLogger(bootstrap.New())
ctrl.SetLogger(zap.New())

mgr, err := ctrl.NewManager(ctrl.GetConfigOrDie(), ctrl.Options{})
if err != nil {
Expand Down
3 changes: 1 addition & 2 deletions examples/scratch-env/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ import (

ctrl "sigs.k8s.io/controller-runtime"
"sigs.k8s.io/controller-runtime/pkg/envtest"
"sigs.k8s.io/controller-runtime/pkg/log/bootstrap"
"sigs.k8s.io/controller-runtime/pkg/log/zap"
)

Expand All @@ -46,7 +45,7 @@ func runMain() int {
flag.CommandLine.AddGoFlagSet(&goFlagSet)
}
flag.Parse()
ctrl.SetLogger(bootstrap.New(zap.UseFlagOptions(loggerOpts)))
ctrl.SetLogger(zap.New(zap.UseFlagOptions(loggerOpts)))

log := ctrl.Log.WithName("main")

Expand Down
4 changes: 2 additions & 2 deletions examples/tokenreview/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,14 @@ import (
_ "k8s.io/client-go/plugin/pkg/client/auth/gcp"
"sigs.k8s.io/controller-runtime/pkg/client/config"
"sigs.k8s.io/controller-runtime/pkg/log"
"sigs.k8s.io/controller-runtime/pkg/log/bootstrap"
"sigs.k8s.io/controller-runtime/pkg/log/zap"
"sigs.k8s.io/controller-runtime/pkg/manager"
"sigs.k8s.io/controller-runtime/pkg/manager/signals"
"sigs.k8s.io/controller-runtime/pkg/webhook/authentication"
)

func init() {
log.SetLogger(bootstrap.New())
log.SetLogger(zap.New())
}

func main() {
Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ require (
github.com/onsi/gomega v1.18.1
github.com/prometheus/client_golang v1.12.1
github.com/prometheus/client_model v0.2.0
go.uber.org/atomic v1.7.0
go.uber.org/goleak v1.1.12
go.uber.org/zap v1.19.1
golang.org/x/sys v0.0.0-20220209214540-3681064d5158
Expand Down Expand Up @@ -57,7 +58,6 @@ require (
github.com/prometheus/common v0.32.1 // indirect
github.com/prometheus/procfs v0.7.3 // indirect
github.com/spf13/pflag v1.0.5 // indirect
go.uber.org/atomic v1.7.0 // indirect
go.uber.org/multierr v1.6.0 // indirect
golang.org/x/net v0.0.0-20220127200216-cd36cc0744dd // indirect
golang.org/x/oauth2 v0.0.0-20211104180415-d3ed0bb246c8 // indirect
Expand Down
18 changes: 0 additions & 18 deletions pkg/log/bootstrap/doc.go

This file was deleted.

37 changes: 0 additions & 37 deletions pkg/log/bootstrap/log.go

This file was deleted.

19 changes: 0 additions & 19 deletions pkg/log/logr/doc.go

This file was deleted.

31 changes: 0 additions & 31 deletions pkg/log/logr/logr_suite_test.go

This file was deleted.

Loading

0 comments on commit 521d348

Please sign in to comment.