Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Suppress finalizer name API warnings in CAPI, CABPK, and KCP controller logs #11242

Conversation

dlipovetsky
Copy link
Contributor

What this PR does / why we need it:
We received a request (#11065) to hide noisy "finalizer name" warnings in controller logs.

In #11129, we hide "finalizer name" warnings by default in the clusterctl move command. This PR extends the approach used there to the Cluster API controllers.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #11065

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 30, 2024
@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-area PR is missing an area label size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 30, 2024
@dlipovetsky
Copy link
Contributor Author

/area logging

@k8s-ci-robot
Copy link
Contributor

@dlipovetsky: The label(s) area/ cannot be applied, because the repository doesn't have them.

In response to this:

/area logging

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added area/logging Issues or PRs related to logging and removed do-not-merge/needs-area PR is missing an area label labels Sep 30, 2024
@dlipovetsky
Copy link
Contributor Author

/cc @sbueringer

@sbueringer
Copy link
Member

Thank you! Really appreciate all the work on this :)

When I have a bit more time again, I'll try to continue the discussion on the CR PR to try to get rid of the default memory leak. But we should be good now at least in CAPI

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 2, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fde3838d9d050f1df29bd06ea27b062c3445855f

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 2, 2024
@k8s-ci-robot k8s-ci-robot merged commit f88d7ae into kubernetes-sigs:main Oct 2, 2024
21 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.9 milestone Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/logging Issues or PRs related to logging cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider filtering out finalizer warnings in controller logs
3 participants