-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Suppress finalizer name API warnings in CAPI, CABPK, and KCP controller logs #11242
✨ Suppress finalizer name API warnings in CAPI, CABPK, and KCP controller logs #11242
Conversation
/area logging |
@dlipovetsky: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/cc @sbueringer |
Thank you! Really appreciate all the work on this :) When I have a bit more time again, I'll try to continue the discussion on the CR PR to try to get rid of the default memory leak. But we should be good now at least in CAPI /lgtm |
LGTM label has been added. Git tree hash: fde3838d9d050f1df29bd06ea27b062c3445855f
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
We received a request (#11065) to hide noisy "finalizer name" warnings in controller logs.
In #11129, we hide "finalizer name" warnings by default in the clusterctl
move
command. This PR extends the approach used there to the Cluster API controllers.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #11065