🌱 Update Kustomize deprecated syntax

[peppi-lotta]

• patchesStrategicMerge -> patches
• patchesJson6902 -> patches
• vars and varReference -> replacements
• bases -> resources

Continuing on where this PR was left off.

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: peppi-lotta / name: Peppi-Lotta (1e56348)

[k8s-ci-robot]

Welcome @peppi-lotta!

It looks like this is your first PR to kubernetes-sigs/cluster-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @peppi-lotta. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[peppi-lotta]

@chrischdi
@kranurag7
@killianmuldoon
@lentzi90

[kranurag7]

Thank you for the patch. I don't get warnings anymore when using kustomize build
Can you please also update the kustomize version (binary and pkg) in Makefile.

cluster-api/Makefile

Lines 106 to 109 in af5f2c9

	KUSTOMIZE_VER := v4.5.2
	KUSTOMIZE_BIN := kustomize
	KUSTOMIZE := $(abspath $(TOOLS_BIN_DIR)/$(KUSTOMIZE_BIN)-$(KUSTOMIZE_VER))
	KUSTOMIZE_PKG := sigs.k8s.io/kustomize/kustomize/v4

[killianmuldoon]

/ok-to-test

/area dependency

Thanks for working on this! It must have been a frustrating one!

[peppi-lotta]

It seem all other tests have passed but golangci-lint test are still running after 20 hours. They should probably be stopped and re-triggered.

[killianmuldoon]

I retriggered the tests - I'm assuming it was some github actions quirk.

[lentzi90]

Great job!

I have just one little concern that I think would be quite easy to address. See the comment below.

[peppi-lotta]

@elmiko and @jackfrancis Please review this as soon as you have time for it.

[lentzi90]

Great!
/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: a19fd89141d54c13f1a0cae7218278d2dbc993c0

[sbueringer]

@chrischdi PTAL :)

[elmiko]

i'm no kustomize expert but this generally makes sense to me
/lgtm

[chrischdi]

No delta on the output files 🎉

/approve

Thanks for working on this!

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [chrischdi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sbueringer]

Thank you very much!