Fix RemoveOwnerRef unit test to use fresh ownerRefs for each test case

Since RemoveOwnerRef may modify the underlying array, the same ownerRefs
should not be used for different test cases.

Author: dlipovetsky

util/util_test.go

@@ -840,17 +840,19 @@ func TestIsSupportedVersionSkew(t *testing.T) {
 
 func TestRemoveOwnerRef(t *testing.T) {
 	g := NewWithT(t)
-	ownerRefs := []metav1.OwnerReference{
-		{
-			APIVersion: "dazzlings.info/v1",
-			Kind:       "Twilight",
-			Name:       "m4g1c",
-		},
-		{
-			APIVersion: "bar.cluster.x-k8s.io/v1beta1",
-			Kind:       "TestCluster",
-			Name:       "bar-1",
-		},
+	makeOwnerRefs := func() []metav1.OwnerReference {
+		return []metav1.OwnerReference{
+			{
+				APIVersion: "dazzlings.info/v1",
+				Kind:       "Twilight",
+				Name:       "m4g1c",
+			},
+			{
+				APIVersion: "bar.cluster.x-k8s.io/v1beta1",
+				Kind:       "TestCluster",
+				Name:       "bar-1",
+			},
+		}
 	}
 
 	tests := []struct {
@@ -874,15 +876,12 @@ func TestRemoveOwnerRef(t *testing.T) {
 			},
 		},
 	}
-
-	originalOwnerRefs := append([]metav1.OwnerReference{}, ownerRefs...)
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
-			result := RemoveOwnerRef(ownerRefs, tt.toBeRemoved)
-			// RemoveOwnerRef should remove the owner ref, if it is found.
-			g.Expect(HasOwnerRef(result, tt.toBeRemoved)).NotTo(BeTrue())
-			// RemoveOwnerRef should not mutate its input.
-			g.Expect(ownerRefs).To(Equal(originalOwnerRefs), "RemoveOwnerRef mutated its input")
+			// Use a fresh ownerRefs slice for each test, because RemoveOwnerRef may modify the underlying array.
+			ownerRefs := makeOwnerRefs()
+			ownerRefs = RemoveOwnerRef(ownerRefs, tt.toBeRemoved)
+			g.Expect(HasOwnerRef(ownerRefs, tt.toBeRemoved)).NotTo(BeTrue())
 		})
 	}
 }