-
Notifications
You must be signed in to change notification settings - Fork 303
0.6.0-rc1 Clusterctl Omnibus PR #764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/retest |
8afa568 to
ee46c70
Compare
ee46c70 to
2eafbf8
Compare
|
i'll sort out lints |
204ecbc to
7e67251
Compare
599da20 to
d87c6ad
Compare
d87c6ad to
f593382
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: randomvariable, yastij The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
e2e startup modified to handle new credential management |
f593382 to
f172196
Compare
Signed-off-by: Naadir Jeewa <jeewan@vmware.com>
f172196 to
cd5ed7f
Compare
|
/lgtm |
What this PR does / why we need it:
Introduces support for clusterctl
The number of templated variables has been reduced to a minimum, so as to minimise the amount to get started. Production users should always modify resultant outputs from cluster
Additionally
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #753
Fixes #774
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODO:
Release note: