Skip to content

Conversation

@randomvariable
Copy link
Member

@randomvariable randomvariable commented Feb 20, 2020

What this PR does / why we need it:
Introduces support for clusterctl
The number of templated variables has been reduced to a minimum, so as to minimise the amount to get started. Production users should always modify resultant outputs from cluster

Additionally

  • Fixes issue with loadbalancer controller and owner references.
  • New dev workflow for clusterctl, similar to the AWS provider
  • Support for tilt
  • Small fix for linters for developers using Linux with SELinux enabled, (sideported from k/k)
  • Fix to readme that incorrectly noted 1.17.4 instead of 1.17.3 OVAs

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #753
Fixes #774

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODO:

  • Create issue to merge with e2e generators as there's overlap there (out of scope for this PR)
  • Create issue around event record pod name

Release note:

* Added support for clusterctlv2, with new cluster template for Cluster API v1alpha3
* [development]: Added tilt configuration for rapid development
* HAProxyLoadBalancer controller will always look up a vSphereCluster in the same namespace
* [development]: Linters work on SELinux enabled systems
* Update links to OVAs
* Running CAPV will no longer run the webhook server by default
* The `--pod-namespace` flag has been removed. Leader election will always look up a configmap in the same namespace in which CAPV runs.
* A `--enable-leader-election` flag has been added to support the deployment of webhooks as a separate instance.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 20, 2020
@k8s-ci-robot k8s-ci-robot requested review from ncdc and sflxn February 20, 2020 15:53
@yastij yastij added this to the v1alpha3 milestone Feb 21, 2020
@yastij
Copy link
Member

yastij commented Feb 24, 2020

/retest

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 26, 2020
@randomvariable
Copy link
Member Author

i'll sort out lints

@randomvariable randomvariable force-pushed the flavors branch 2 times, most recently from 204ecbc to 7e67251 Compare February 26, 2020 18:14
@randomvariable randomvariable force-pushed the flavors branch 7 times, most recently from 599da20 to d87c6ad Compare February 27, 2020 12:50
@randomvariable randomvariable changed the title [wip] flavorgen: Adds a generator for clusterctl flavo(u)rs flavorgen: Adds a generator for clusterctl flavo(u)rs Feb 27, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 27, 2020
@randomvariable randomvariable changed the title flavorgen: Adds a generator for clusterctl flavo(u)rs 0.6.0-rc1 Clusterctl Omnibus PR Feb 27, 2020
Copy link
Member

@yastij yastij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 27, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: randomvariable, yastij

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2020
@yastij
Copy link
Member

yastij commented Feb 27, 2020

/retest

@randomvariable
Copy link
Member Author

e2e startup modified to handle new credential management

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 27, 2020
Signed-off-by: Naadir Jeewa <jeewan@vmware.com>
@yastij
Copy link
Member

yastij commented Feb 27, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 27, 2020
@k8s-ci-robot k8s-ci-robot merged commit 934f2c5 into kubernetes-sigs:master Feb 27, 2020
@randomvariable randomvariable deleted the flavors branch March 2, 2020 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Validate / fixup manager defaults provide workload cluster template for clusterctlv2

3 participants