Skip to content

Update docs with references to release-0.9 #2082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

Prajyot-Parab
Copy link
Contributor

What this PR does / why we need it:

  • Update docs with references to release-0.9

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

/area provider/ibmcloud

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

Update docs with references to release-0.9

Signed-off-by: Prajyot Parab <Prajyot.Parab2@ibm.com>
@k8s-ci-robot k8s-ci-robot added area/provider/ibmcloud Issues or PRs related to ibmcloud provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 3, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 3, 2024
Copy link

netlify bot commented Dec 3, 2024

Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Name Link
🔨 Latest commit 6e02ea6
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-ibmcloud/deploys/674e94efebf8470008efc16c
😎 Deploy Preview https://deploy-preview-2082--kubernetes-sigs-cluster-api-ibmcloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@Amulyam24 Amulyam24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 3, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Amulyam24, Prajyot-Parab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mkumatag
Copy link
Member

mkumatag commented Dec 3, 2024

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 3, 2024
* [main.cluster-api-ibmcloud.sigs.k8s.io](https://main.cluster-api-ibmcloud.sigs.k8s.io)
* [release-0-9.cluster-api-ibmcloud.sigs.k8s.io](https://release-0-9.cluster-api-ibmcloud.sigs.k8s.io/)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this link doesn't work, not sure netlify really got fixed or not!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope not yet fixed and same issue with 0.8
I am reaching out to them via slack again to get this fixed asap.

Copy link
Contributor

@Amulyam24 Amulyam24 Dec 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest I could find out is it is failing post this change - kubernetes/k8s.io#5745

previous issue - kubernetes/org#4318
open issue - kubernetes/org#5136

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

release-0.8 url got fixed, I am not able to see release-0.9 yet in the list of branch subdomains yet.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

release-0.9 fixed.

@Prajyot-Parab
Copy link
Contributor Author

/retest all

@k8s-ci-robot
Copy link
Contributor

@Prajyot-Parab: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test pull-cluster-api-provider-ccm-image
  • /test pull-cluster-api-provider-ibmcloud-build
  • /test pull-cluster-api-provider-ibmcloud-coverage
  • /test pull-cluster-api-provider-ibmcloud-make
  • /test pull-cluster-api-provider-ibmcloud-smoke-test
  • /test pull-cluster-api-provider-ibmcloud-test
  • /test pull-cluster-api-provider-ibmcloud-verify

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-provider-ibmcloud-apidiff

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-provider-ibmcloud-apidiff
  • pull-cluster-api-provider-ibmcloud-build
  • pull-cluster-api-provider-ibmcloud-coverage
  • pull-cluster-api-provider-ibmcloud-make
  • pull-cluster-api-provider-ibmcloud-smoke-test
  • pull-cluster-api-provider-ibmcloud-test
  • pull-cluster-api-provider-ibmcloud-verify

In response to this:

/retest all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Prajyot-Parab
Copy link
Contributor Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 5, 2024
@k8s-ci-robot k8s-ci-robot merged commit 9bc5ae4 into kubernetes-sigs:main Dec 5, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/ibmcloud Issues or PRs related to ibmcloud provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants