-
Notifications
You must be signed in to change notification settings - Fork 89
Use cloud-provider template for PowerVS e2e by default #1861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/hold Verified the template by testing locally
However, waiting for a successful run in CI(facing few issues, not related to this change) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Amulyam24, mkumatag The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
E2E succeeded, minor change is needed in e2e script. Will create a different PR which will have to be back ported. /unhold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
I think with this change we can plan to remove the older template and make it as defualt and also we can deprecate and remove the V1 provider id format.
What this PR does / why we need it:
3CP + 1W cluster creation has been failing. 1CP and 1W are created successfully but the other 2 CP creation is not triggered due to a condition check failing on first CP
On further debugging, it was discovered the nodes were not assigned IP addresses and this was due to the change introduced in kubernetes/kubernetes#121028 in k8s v 1.29
As a result, switch to using cloud provider template for PowerVS CI which will be responsible for setting the IP.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
/area provider/ibmcloud
Release note: