-
Notifications
You must be signed in to change notification settings - Fork 89
Open
Labels
area/provider/ibmcloudIssues or PRs related to ibmcloud providerIssues or PRs related to ibmcloud providergood first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.kind/cleanupCategorizes issue or PR as related to cleaning up code, process, or technical debt.Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Description
With the recent bump of golangci-linter version from 2.1.6 to 2.3.1, Under the revive
linter, a certain rule - avoid meaningless package names
has been skipped to allow the version update through #2457.
To fix this issue, one may need to remove the 'var-naming: avoid meaningless package names - rule
under exclusions
from the .golangci.yml file from the repository root and run the linter locally with make lint
command. Please make appropriate changes to suppress the issue.
A couple of those identified in the previous runs are: https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/kubernetes-sigs_cluster-api-provider-ibmcloud/2451/pull-cluster-api-provider-ibmcloud-test/1952628794493767680
cmd/capibmadm/utils/utils.go:18:9: var-naming: avoid meaningless package names (revive)
package utils
^
pkg/cloud/services/utils/paging.go:17:9: var-naming: avoid meaningless package names (revive)
package utils
^
util/util.go:17:9: var-naming: avoid meaningless package names (revive)
package util
^
Metadata
Metadata
Assignees
Labels
area/provider/ibmcloudIssues or PRs related to ibmcloud providerIssues or PRs related to ibmcloud providergood first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.kind/cleanupCategorizes issue or PR as related to cleaning up code, process, or technical debt.Categorizes issue or PR as related to cleaning up code, process, or technical debt.