-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GPU/Accelerator support to VMs in GCPMachineTemplate #1341
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jwmay2012 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @jwmay2012. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for kubernetes-sigs-cluster-api-gcp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
cddf743
to
b0eb05e
Compare
Thanks @jwmay2012 /ok-to-test |
@jwmay2012 - would you be able to run |
b0eb05e
to
7b8e870
Compare
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adds the ability to configure Guest Accelerators like GPUs in a GCPMachineTemplate
Fixes #289
Special notes for your reviewer:
Tested and creates machines with GPUs correctly. After installing drivers and nvidia container runtime on the node, was able to get the GPU to run successfully in a Pod.
If you try to use an accelerator on the wrong instance type it will have an instance reconcile error from GCP that describes the improper API use.
OnHostMaintenance
must be set toTERMINATE
for GPU enabled machines.https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/compute_instance#guest_accelerator
Confirmed this is correct. Instance reconcile is rejected by GCP otherwise.
I set this field automatically.
TODOs:
Release note: