-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump setup-envtest to use new controller-tools binaries #1248
Conversation
This is a commit from CR main (22.05.2024). Intentionally using a commit from main to use a setup-envtest version that uses binaries from controller-tools, not GCS. CR PR: kubernetes-sigs/controller-runtime#2811
✅ Deploy Preview for kubernetes-sigs-cluster-api-gcp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/assign @cpanato |
/cherry-pick release-1.6 |
@damdo: once the present PR merges, I will cherry-pick it on top of release-1.6 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, damdo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@damdo: new pull request created: #1249 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This was brought up in the weekly CAPI community meeting.
This is a commit from CR main (22.05.2024).
Intentionally using a commit from main to use a setup-envtest version that uses binaries from controller-tools, not GCS. CR PR: kubernetes-sigs/controller-runtime#2811
Release note: