Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump setup-envtest to use new controller-tools binaries #1248

Merged
merged 1 commit into from
May 30, 2024

Conversation

damdo
Copy link
Member

@damdo damdo commented May 30, 2024

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
This was brought up in the weekly CAPI community meeting.

This is a commit from CR main (22.05.2024).
Intentionally using a commit from main to use a setup-envtest version that uses binaries from controller-tools, not GCS. CR PR: kubernetes-sigs/controller-runtime#2811

Release note:

NONE

This is a commit from CR main (22.05.2024).
Intentionally using a commit from main to use a setup-envtest version
that uses binaries from controller-tools, not GCS.
CR PR: kubernetes-sigs/controller-runtime#2811
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 30, 2024
@k8s-ci-robot k8s-ci-robot requested review from cpanato and dims May 30, 2024 15:29
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 30, 2024
Copy link

netlify bot commented May 30, 2024

Deploy Preview for kubernetes-sigs-cluster-api-gcp ready!

Name Link
🔨 Latest commit d031548
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-gcp/deploys/66589b368f4ec70007724abb
😎 Deploy Preview https://deploy-preview-1248--kubernetes-sigs-cluster-api-gcp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@damdo damdo changed the title bump: setup-envtest Bump setup-envtest to use new controller-tools binaries May 30, 2024
@damdo
Copy link
Member Author

damdo commented May 30, 2024

/assign @cpanato

@damdo
Copy link
Member Author

damdo commented May 30, 2024

/cherry-pick release-1.6

@k8s-infra-cherrypick-robot

@damdo: once the present PR merges, I will cherry-pick it on top of release-1.6 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 30, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, damdo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 30, 2024
@k8s-ci-robot k8s-ci-robot merged commit 90b1335 into kubernetes-sigs:main May 30, 2024
22 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.1.0 milestone May 30, 2024
@k8s-infra-cherrypick-robot

@damdo: new pull request created: #1249

In response to this:

/cherry-pick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants