Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple workers for controllers #274

Closed
vignesh-goutham opened this issue Jun 15, 2023 · 3 comments
Closed

Multiple workers for controllers #274

vignesh-goutham opened this issue Jun 15, 2023 · 3 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@vignesh-goutham
Copy link
Contributor

/kind feature

Describe the solution you'd like
[A clear and concise description of what you want to happen.]
CAPC provider uses controller-runtime for all of its controllers. When each of the controller is set up with a manager, CAPC should configure controller-runtime to use multiple concurrent workers for each controller. This could be customizable with input arguments as well.

In order to support multiple concurrent workers, there might be code changes required to, in order to stop multiple workers accessing same resource. CAPI has a clean implementation of caching and locking that could be used as inspiration for this.

This will help when CAPC is managing multiple workload clusters and especially when the environment has a lot of operations going on resulting in lot of reconcile tasks being queued up quickly more than a single worker can serve.

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 15, 2023
@chrisdoherty4
Copy link
Member

/assign chrisdoherty4

@chrisdoherty4
Copy link
Member

Everything should have been introduced with the various PRs.

/close

@k8s-ci-robot
Copy link
Contributor

@chrisdoherty4: Closing this issue.

In response to this:

Everything should have been introduced with the various PRs.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants