TestReconcileInboundNATRule test cases can not be run in parallel

[jackfrancis]

/kind bug

[Before submitting an issue, have you checked the Troubleshooting Guide?]

What steps did you take and what happened:
[A clear and concise description of what the bug is.]

@mboersma determined in #2646 that the cases in the TestReconcileInboundNATRule unit test trigger the race detector. This could be an innocuous outcome of the way those tests are setup, or it could be that refactoring the tests to enable parallel cases to run is not worth the effort; or it could mean that there is actually something worrisome happening under the hood.

Let's investigate and rule out anything worrisome.

What did you expect to happen:

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Environment:

• cluster-api-provider-azure version:
• Kubernetes version: (use kubectl version):
• OS (e.g. from /etc/os-release):

[ShivamTyagi12345]

Is this issue fixed with PR #2646 ? If not! May i take this up? @jackfrancis

/ assign

[mboersma]

In #2646 we just commented out t.Parallel() to fix the problem. Maybe that's fine, but maybe there's something in the test itself that could be changed to allow the t.Parallel() line to be restored and have go test -race still work.

Thanks for taking a look!

/assign @ShivamTyagi12345

[ShivamTyagi12345]

Started with this issue. Apologies for the delay due to Exams, and thanks for your reply

[willie-yao]

Hi @ShivamTyagi12345, thanks for taking a look at this issue! Are you still working on this as of now?

[dtzar]

@ShivamTyagi12345 are you still working on this?

[mboersma]

/unassign @ShivamTyagi12345