Switch bash to cloud config #510

sfzylad · 2019-01-22T09:22:26Z

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #205

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

k8s-ci-robot · 2019-01-22T09:22:40Z

Hi @sfzylad. Thanks for your PR.

I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

randomvariable · 2019-01-22T10:59:53Z

Bit more to this one.

@detiber's been working on a kubeadm module for cloud-init. Probably worth a sync up.

sfzylad · 2019-01-22T23:33:17Z

@randomvariable, thanks for heads up.
@detiber, could you point me to the module you worked on?

vincepri · 2019-01-23T04:37:20Z

Not sure of the current status, but there is an old PR open around cloud-init #96

sfzylad · 2019-01-23T06:19:29Z

Yeah, I've found this one too and I wondered about the status as this PR since the last commit there has been done in September last year.

ashish-amarnath · 2019-01-23T08:25:38Z

Hi @sfzylad 👋
If you do continue to work on this I have this PR #502 that kinda simplifies the bash script, removing the kubectl commands that are run. This should simplify the switch to cloud-config.

sfzylad · 2019-01-23T09:51:11Z

Hi @ashish-amarnath 👋

I've got node to work with cloud-config (I'm about to switch control plane too). It still uses text/template but makes it a bit less magical. Please tell me your thoughts.

pkg/cloud/aws/services/userdata/userdata.go

pkg/cloud/aws/services/userdata/node.go

vincepri · 2019-01-29T18:07:00Z

/ok-to-test

sfzylad · 2019-02-06T10:52:34Z

This PR assumes #538 is merged, otherwise ami object in machines.yaml manifest has to be set to custom AMI.

pkg/cloud/aws/services/userdata/controlplane.go

ashish-amarnath · 2019-02-07T18:38:18Z

pkg/cloud/aws/services/userdata/controlplane.go

+        localAPIEndpoint:
+          advertiseAddress: {{ "{{ ds.meta_data.local_ipv4 }}" }}
+          bindPort: 6443
+kubeadm:


can we also keep the --v=10? It was super useful in debugging.

To add support, we'll need to extend the cloud-init module here: https://github.com/detiber/cloud-init/tree/cluster-api

Is it something that we want in scope of solving #205?

I don't think it is in scope for #205 @ashish-amarnath do you mind filing an issue for followup?

created #559

pkg/cloud/aws/services/userdata/controlplane.go

…ting new node

detiber · 2019-02-08T18:33:51Z

/check-cla

detiber · 2019-02-08T18:35:24Z

/approve
/assign @chuckha

Leaving lgtm to @chuckha

k8s-ci-robot · 2019-02-08T18:35:29Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: detiber, sfzylad

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [detiber]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

chuckha · 2019-02-08T21:15:53Z

/lgtm

thank you!

…-to-log OCPBUGS-33170: All containers must fallback to logs on error

k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 22, 2019

k8s-ci-robot requested review from detiber and randomvariable January 22, 2019 09:22

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 22, 2019

detiber reviewed Jan 29, 2019

View reviewed changes

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 29, 2019

sfzylad force-pushed the cloud-config branch 2 times, most recently from d6dc8d6 to 3b2df18 Compare February 6, 2019 06:01

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 6, 2019

sfzylad force-pushed the cloud-config branch from 386d846 to e4e2991 Compare February 7, 2019 07:02

sfzylad changed the title ~~[WIP] Switch bash to cloud config~~ Switch bash to cloud config Feb 7, 2019

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 7, 2019

detiber reviewed Feb 7, 2019

View reviewed changes

pkg/cloud/aws/services/userdata/controlplane.go Show resolved Hide resolved

ashish-amarnath reviewed Feb 7, 2019

View reviewed changes

pkg/cloud/aws/services/userdata/controlplane.go Show resolved Hide resolved

sfzylad added 2 commits February 8, 2019 15:13

Switch machine acuator to use cloud config instead of bash while crea…

cce454f

…ting new node

fix yaml

156a6ec

sfzylad added 18 commits February 8, 2019 15:13

go templates are hard

1063332

Use kubeadm module in cloud-init configuration

ac25ab9

Remove copyright header

c7bc796

Change permissions for kubeadm configuration

7d45cbf

Remove unused variable

beb7393

Add controlplane cloud-config template

574fd8e

Switch controlplane to use cloud-init

0b11490

yaml doesn't like tabs

b1728ee

fix indents in yaml template

ca6f403

Add helper functions for template generation

a4668e5

encode certificates in base64

75ca5f1

Use Base64Encode template function when initializing cluster

1845ac7

Remove unused variable

368c3e4

Make controlplane to use cloud-init when joining cluster

4e7b2b8

remove trailing tab

e897848

Remove unused variable

433cdcd

yaml is hell

9423150

Join the controlplane

842a640

sfzylad force-pushed the cloud-config branch from a22a940 to 842a640 Compare February 8, 2019 07:13

k8s-ci-robot assigned chuckha Feb 8, 2019

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2019

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 8, 2019

k8s-ci-robot merged commit d9e9820 into kubernetes-sigs:master Feb 8, 2019

sfzylad deleted the cloud-config branch February 11, 2019 06:28

sfzylad mentioned this pull request Feb 12, 2019

REQUEST: New membership for sfzylad kubernetes/org#470

Closed

6 tasks

damdo pushed a commit to damdo/cluster-api-provider-aws that referenced this pull request May 22, 2024

Merge pull request kubernetes-sigs#510 from damdo/container-fall-back…

aaaf00b

…-to-log OCPBUGS-33170: All containers must fallback to logs on error

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Switch bash to cloud config #510

Switch bash to cloud config #510

sfzylad commented Jan 22, 2019

k8s-ci-robot commented Jan 22, 2019

randomvariable commented Jan 22, 2019

sfzylad commented Jan 22, 2019

vincepri commented Jan 23, 2019

sfzylad commented Jan 23, 2019

ashish-amarnath commented Jan 23, 2019

sfzylad commented Jan 23, 2019 •

edited

Loading

vincepri commented Jan 29, 2019

sfzylad commented Feb 6, 2019

ashish-amarnath Feb 7, 2019 •

edited

Loading

detiber Feb 7, 2019

sfzylad Feb 8, 2019

detiber Feb 8, 2019

ashish-amarnath Feb 8, 2019 •

edited

Loading

detiber commented Feb 8, 2019

detiber commented Feb 8, 2019

k8s-ci-robot commented Feb 8, 2019

chuckha commented Feb 8, 2019

Switch bash to cloud config #510

Switch bash to cloud config #510

Conversation

sfzylad commented Jan 22, 2019

k8s-ci-robot commented Jan 22, 2019

randomvariable commented Jan 22, 2019

sfzylad commented Jan 22, 2019

vincepri commented Jan 23, 2019

sfzylad commented Jan 23, 2019

ashish-amarnath commented Jan 23, 2019

sfzylad commented Jan 23, 2019 • edited Loading

vincepri commented Jan 29, 2019

sfzylad commented Feb 6, 2019

ashish-amarnath Feb 7, 2019 • edited Loading

Choose a reason for hiding this comment

detiber Feb 7, 2019

Choose a reason for hiding this comment

sfzylad Feb 8, 2019

Choose a reason for hiding this comment

detiber Feb 8, 2019

Choose a reason for hiding this comment

ashish-amarnath Feb 8, 2019 • edited Loading

Choose a reason for hiding this comment

detiber commented Feb 8, 2019

detiber commented Feb 8, 2019

k8s-ci-robot commented Feb 8, 2019

chuckha commented Feb 8, 2019

sfzylad commented Jan 23, 2019 •

edited

Loading

ashish-amarnath Feb 7, 2019 •

edited

Loading

ashish-amarnath Feb 8, 2019 •

edited

Loading