fix: prevent implicit memory aliasing in for loops

In golang the iteration variable is reused. At each iteration, the value
of the next element in the range expression is assigned to the iteration
variable; "provider" doesn't change, only its value changes. Hence, the
expression &provider is referring to the same location in memory.

The recommended solution for the issue is to redeclare "provider" inside
the for loop.

For more information:
golang/go#56010
https://husni.dev/beware-of-implicit-memory-aliasing-in-go-foor-loop/

Author: Fedosin

internal/controller/genericprovider/bootstrapprovider_wrapper.go

@@ -64,7 +64,9 @@ type BootstrapProviderListWrapper struct {
 
 func (b *BootstrapProviderListWrapper) GetItems() []GenericProvider {
 	providers := []GenericProvider{}
+
 	for _, provider := range b.Items {
+		provider := provider
 		providers = append(providers, &BootstrapProviderWrapper{&provider})
 	}
 

internal/controller/genericprovider/controlplaneprovider_wrapper.go

@@ -64,7 +64,9 @@ type ControlPlaneProviderListWrapper struct {
 
 func (c *ControlPlaneProviderListWrapper) GetItems() []GenericProvider {
 	providers := []GenericProvider{}
+
 	for _, provider := range c.Items {
+		provider := provider
 		providers = append(providers, &ControlPlaneProviderWrapper{&provider})
 	}
 

internal/controller/genericprovider/coreprovider_wrapper.go

@@ -64,7 +64,9 @@ type CoreProviderListWrapper struct {
 
 func (c *CoreProviderListWrapper) GetItems() []GenericProvider {
 	providers := []GenericProvider{}
+
 	for _, provider := range c.Items {
+		provider := provider
 		providers = append(providers, &CoreProviderWrapper{&provider})
 	}
 

internal/controller/genericprovider/infrastructureprovider_wrapper.go

@@ -64,7 +64,9 @@ type InfrastructureProviderListWrapper struct {
 
 func (i *InfrastructureProviderListWrapper) GetItems() []GenericProvider {
 	providers := []GenericProvider{}
+
 	for _, provider := range i.Items {
+		provider := provider
 		providers = append(providers, &InfrastructureProviderWrapper{&provider})
 	}