Additional fixes in the code

Signed-off-by: Furkat Gofurov <furkat.gofurov@suse.com>

Author: furkatgofurov7

cmd/plugin/cmd/upgrade_plan.go

@@ -178,10 +178,14 @@ func runUpgradePlan() error {
 
 	w := tabwriter.NewWriter(os.Stdout, 10, 4, 3, ' ', 0)
 
-	fmt.Fprintln(w, "NAME\tNAMESPACE\tTYPE\tCURRENT VERSION\tNEXT VERSION")
+	if _, err := fmt.Fprintln(w, "NAME\tNAMESPACE\tTYPE\tCURRENT VERSION\tNEXT VERSION"); err != nil {
+		return err
+	}
 
 	for _, upgradeItem := range upgradePlan.Providers {
-		fmt.Fprintf(w, "%s\t%s\t%s\t%s\t%s\n", upgradeItem.Name, upgradeItem.Namespace, upgradeItem.Type, upgradeItem.CurrentVersion, prettifyTargetVersion(upgradeItem.NextVersion))
+		if _, err := fmt.Fprintf(w, "%s\t%s\t%s\t%s\t%s\n", upgradeItem.Name, upgradeItem.Namespace, upgradeItem.Type, upgradeItem.CurrentVersion, prettifyTargetVersion(upgradeItem.NextVersion)); err != nil {
+			return err
+		}
 
 		if upgradeItem.NextVersion != "" {
 			upgradeAvailable = true

internal/controller/component_customizer.go

@@ -145,7 +145,8 @@ func customizeDeployment(dSpec *operatorv1.DeploymentSpec, mSpec *operatorv1.Man
 
 func customizeDeploymentSpec(dSpec operatorv1.DeploymentSpec, d *appsv1.Deployment) {
 	if dSpec.Replicas != nil {
-		d.Spec.Replicas = ptr.To(int32(*dSpec.Replicas))
+		replicas := int32(*dSpec.Replicas) //nolint:gosec
+		d.Spec.Replicas = ptr.To(replicas)
 	}
 
 	if dSpec.Affinity != nil {

internal/controller/genericprovider_controller.go

@@ -182,7 +182,7 @@ func (r *GenericProviderReconciler) reconcile(ctx context.Context, provider gene
 		if err != nil {
 			var pe *PhaseError
 			if errors.As(err, &pe) {
-				conditions.Set(provider, conditions.FalseCondition(pe.Type, pe.Reason, pe.Severity, err.Error()))
+				conditions.Set(provider, conditions.FalseCondition(pe.Type, pe.Reason, pe.Severity, "%s", err.Error()))
 			}
 		}
 
@@ -214,7 +214,7 @@ func (r *GenericProviderReconciler) reconcileDelete(ctx context.Context, provide
 		if err != nil {
 			var pe *PhaseError
 			if errors.As(err, &pe) {
-				conditions.Set(provider, conditions.FalseCondition(pe.Type, pe.Reason, pe.Severity, err.Error()))
+				conditions.Set(provider, conditions.FalseCondition(pe.Type, pe.Reason, pe.Severity, "%s", err.Error()))
 			}
 		}
 

internal/controller/oci_source.go

@@ -125,7 +125,7 @@ func (m mapStore) Exists(ctx context.Context, target ocispec.Descriptor) (bool,
 
 // Fetch implements oras.Target.
 func (m mapStore) Fetch(ctx context.Context, target ocispec.Descriptor) (io.ReadCloser, error) {
-	return nil, nil
+	return nil, nil //nolint:nilnil
 }
 
 // Push implements oras.Target.

internal/controller/preflight_checks.go

@@ -45,10 +45,6 @@ var (
 	moreThanOneCoreProviderInstanceExistsMessage = "CoreProvider already exists in the cluster. Only one is allowed."
 	moreThanOneProviderInstanceExistsMessage     = "There is already a %s with name %s in the cluster. Only one is allowed."
 	capiVersionIncompatibilityMessage            = "CAPI operator is only compatible with %s providers, detected %s for provider %s."
-	invalidGithubTokenMessage                    = "Invalid github token, please check your github token value and its permissions" //nolint:gosec
-	waitingForCoreProviderReadyMessage           = "Waiting for the core provider to be installed."
-	incorrectCoreProviderNameMessage             = "Incorrect CoreProvider name: %s. It should be %s"
-	unsupportedProviderDowngradeMessage          = "Downgrade is not supported for provider %s"
 )
 
 // preflightChecks performs preflight checks before installing provider.
@@ -73,7 +69,7 @@ func preflightChecks(ctx context.Context, c client.Client, provider genericprovi
 				operatorv1.PreflightCheckCondition,
 				operatorv1.IncorrectCoreProviderNameReason,
 				clusterv1.ConditionSeverityError,
-				fmt.Sprintf(incorrectCoreProviderNameMessage, provider.GetName(), configclient.ClusterAPIProviderName),
+				"Incorrect CoreProvider name",
 			))
 
 			return ctrl.Result{}, fmt.Errorf("incorrect CoreProvider name: %s, it should be %s", provider.GetName(), configclient.ClusterAPIProviderName)
@@ -129,7 +125,7 @@ func preflightChecks(ctx context.Context, c client.Client, provider genericprovi
 					operatorv1.PreflightCheckCondition,
 					operatorv1.InvalidGithubTokenReason,
 					clusterv1.ConditionSeverityError,
-					invalidGithubTokenMessage,
+					"Invalid github token, please check your github token value and its permissions",
 				))
 
 				return ctrl.Result{}, fmt.Errorf("failed to validate provided github token: %w", err)
@@ -182,12 +178,11 @@ func preflightChecks(ctx context.Context, c client.Client, provider genericprovi
 		}
 
 		if !ready {
-			log.Info(waitingForCoreProviderReadyMessage)
 			conditions.Set(provider, conditions.FalseCondition(
 				operatorv1.PreflightCheckCondition,
 				operatorv1.WaitingForCoreProviderReadyReason,
 				clusterv1.ConditionSeverityInfo,
-				waitingForCoreProviderReadyMessage,
+				"Waiting for the core provider to be installed.",
 			))
 
 			return ctrl.Result{RequeueAfter: preflightFailedRequeueAfter}, nil
@@ -213,7 +208,7 @@ func checkProviderVersion(ctx context.Context, providerVersion string, provider
 			operatorv1.PreflightCheckCondition,
 			operatorv1.IncorrectVersionFormatReason,
 			clusterv1.ConditionSeverityError,
-			err.Error(),
+			"%s", err.Error(),
 		))
 
 		return fmt.Errorf("version contains invalid value for provider %q", provider.GetName())
@@ -231,7 +226,7 @@ func checkProviderVersion(ctx context.Context, providerVersion string, provider
 				operatorv1.PreflightCheckCondition,
 				operatorv1.UnsupportedProviderDowngradeReason,
 				clusterv1.ConditionSeverityError,
-				fmt.Sprintf(unsupportedProviderDowngradeMessage, provider.GetName()),
+				"Downgrade is not supported for provider",
 			))
 
 			return fmt.Errorf("downgrade is not supported for provider %q", provider.GetName())