-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: change tgb field to lowercase everywhere to avoid logs dropped… #4134
base: main
Are you sure you want to change the base?
Conversation
… due to conflict in OS/ES Signed-off-by: Daniel Brown <daniel.brown2@sainsburys.co.uk>
The committers listed above are authorized under a signed CLA. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 94DanielBrown The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @94DanielBrown! |
Hi @94DanielBrown. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
I've tested in our lab environment and fields for the messages that were previously uppercase are now in lower case and there's no alerts for logs being dropped |
I don't have a problem with the change, but I think there is something wrong with your ElasticSearch setup. |
/ok-to-test |
/lgtm |
… due to conflict in OS/ES
Issue
#4133
Description
Changed places where TGB field was logged in uppercase to lowercase
I've built binary and pushed a docker image, we don't get this in our lab environment so I'm looking into how to get these logs to occur still
Checklist
README.md
, or thedocs
directory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯