Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add authenticationConfiguration to Ingress Class Params #4129

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

kellyyan
Copy link
Contributor

@kellyyan kellyyan commented Apr 4, 2025

Issue

#3858

Description

  • Add authenticationConfiguration to IngressClassParams, allowing users to configure the authentication for all Ingresses in the IngressGroup associated with the IngressClass
  • Add error handling to ensure authentication configuration is set properly
  • Added tests
    • pkg/ingress/auth_config_builder_test.go
    • pkg/ingress/enhanced_backend_builder_test.go
    • pkg/ingress/reference_indexer_test.go
  • Added documentation to ingress_class.md
  • Minor formating fixes
  • Manually tested using Ingress manifests
    • Test: create ALB with OIDC authentication configuration
    • Test: create ALB with Amazon Cognito authentication configuration
    • Test: create ALB with no authentication configuration

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 4, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kellyyan
Once this PR has been reviewed and has the lgtm label, please assign m00nf1sh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 4, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @kellyyan. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 4, 2025
@shraddhabang
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 5, 2025
@shraddhabang
Copy link
Collaborator

/retest

ipv4IPAMPoolId:
description: IPv4IPAMPoolId defines the IPAM pool ID used for
IPv4 Addresses on the ALB.
- additionalPrinterColumns:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the CRDs for helm as well by running make crds.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in revision

@kellyyan kellyyan force-pushed the auth-ingressgroup branch from e4b5256 to ebbceec Compare April 7, 2025 20:28

if ingressClassParamsAvailable {
// Indexes using IngressClassParams should only be set up if IngressClassParams Customer Resource Definition (CRD) is installed
if err := fieldIndexer.IndexField(ctx, &networking.Ingress{}, ingress.IndexKeySecretRefName,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of repeating the same index field statement twice can you do something like this:

var ingClassParams *elbv2api.IngressClassParams
if ingressClassParamsAvailable {
  ingClassParams = &elbv2api.IngressClassParams{}
}

Then you can set up the indexers ->

	if err := fieldIndexer.IndexField(ctx, &networking.Ingress{}, ingress.IndexKeySecretRefName,
			func(obj client.Object) []string {
				return r.referenceIndexer.BuildSecretRefIndexes(context.Background(), ingClassParams, obj.(*networking.Ingress))
			},
		); err != nil {
			return err
		}
		if err := fieldIndexer.IndexField(ctx, &corev1.Service{}, ingress.IndexKeySecretRefName,
			func(obj client.Object) []string {
				return r.referenceIndexer.BuildSecretRefIndexes(context.Background(), ingClassParams, obj.(*corev1.Service))
			},
		); err != nil {
			return err
		}

@kellyyan kellyyan force-pushed the auth-ingressgroup branch from ebbceec to 41843f3 Compare April 8, 2025 04:17
@kellyyan kellyyan force-pushed the auth-ingressgroup branch from 41843f3 to 8d85071 Compare April 8, 2025 19:59
@kellyyan
Copy link
Contributor Author

/retest

@k8s-ci-robot
Copy link
Contributor

@kellyyan: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-aws-load-balancer-controller-e2e-test 885756c link true /test pull-aws-load-balancer-controller-e2e-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants