Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in Helm chart values file podLabel should be podLabels #1319

Open
ismaillatona opened this issue Apr 17, 2024 · 4 comments
Open

Typo in Helm chart values file podLabel should be podLabels #1319

ismaillatona opened this issue Apr 17, 2024 · 4 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@ismaillatona
Copy link

/kind bug

What happened?
Pod labels are not set on the controller pods.
While looking at the default values file there is a typo at controller.podLabel it should be controller.podLabels as referenced in the templates
What you expected to happen?
I expected pod labels to be set on the controller pods
How to reproduce it (as minimally and precisely as possible)?
Setting podLabel value does not set the controller pod labels
Anything else we need to know?:

Environment

  • Kubernetes version (use kubectl version):
  • Driver version:

Please also attach debug logs to help us better diagnose

  • Instructions to gather debug logs can be found here
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Apr 17, 2024
@r-yabyab
Copy link

/assign

@r-yabyab r-yabyab removed their assignment May 15, 2024
@r-yabyab
Copy link

The chart value's controller.podLabel works for me. Couldn't get controller.podLabels to work.

@chris-bosman
Copy link

A few more details:

In values.yaml, here, the name of the variable is PodLabel.

But it does not appear as though this will ever modify the tags on the deployed pods, since the code for the pod's labels here references a variable called PodLabels.

The two files need to be reconciled to agree on the variable name. The simplest would simply be renaming controller.PodLabel to controller.PodLabels to agree with what's currently in the controller deployment definition.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

5 participants