Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy CSIDriver object api version dynamically based on kubeVersion #890

Closed

Conversation

AndyXiangLi
Copy link
Contributor

@AndyXiangLi AndyXiangLi commented May 18, 2021

Is this a bug fix or adding new feature?
Fixes #887
What is this PR about? / Why do we need it?
storage.k8s.io/v1beta1 CSIDriver is deprecated in v1.19+, unavailable in v1.22+;
CSIDriver is general available in storage.k8s.io/v1 since v1.19
Instead of using v1beta1 version for all helm deployment, check the kubeVersion first in helm deployment and use v1 for clusterVersion >=1.19 and v1beta1 for clusterVersion >=1.17 and < 1.19

What testing is done?
Tested in 1.17, 1.18, 1.19 cluster

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 18, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AndyXiangLi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from gnufied and vdhanan May 18, 2021 22:25
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 18, 2021
@coveralls
Copy link

coveralls commented May 18, 2021

Pull Request Test Coverage Report for Build 1964

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.188%

Totals Coverage Status
Change from base Build 1955: 0.0%
Covered Lines: 1990
Relevant Lines: 2513

💛 - Coveralls

@AndyXiangLi AndyXiangLi reopened this May 18, 2021
@AndyXiangLi
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSIDriver v1 is not available in 1.17
4 participants