Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

csi.storage.k8s.io/fstype is case sensitive #807

Merged
merged 1 commit into from
Mar 22, 2021

Conversation

jsafrane
Copy link
Contributor

Is this a bug fix or adding new feature?
bug

What is this PR about? / Why do we need it?
The external-provisioner does not treat csi.storage.k8s.io/fstype as case-insensitive. Update the documentation accordingly.

What testing is done?
None :-)

The external-provisioner does not treat csi.storage.k8s.io/fstype as
case-insensitive. Update the documentation accordingly.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 22, 2021
@k8s-ci-robot k8s-ci-robot requested review from ddebroy and gnufied March 22, 2021 18:10
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1746

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 81.789%

Totals Coverage Status
Change from base Build 1745: 0.0%
Covered Lines: 1756
Relevant Lines: 2147

💛 - Coveralls

@wongma7
Copy link
Contributor

wongma7 commented Mar 22, 2021

w8 isn't this a bug in external provisioner too then?

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 22, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 189682b into kubernetes-sigs:master Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants