Use buildx in cloudbuild #658
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wongma7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
cloudbuild.yaml
Outdated
| @@ -2,18 +2,26 @@ timeout: 1200s | |||
| steps: | |||
| - name: gcr.io/cloud-builders/docker | |||
| args: | |||
| - HOME=/root | |||
There was a problem hiding this comment.
https://github.com/kubernetes/test-infra/tree/master/config/jobs/image-pushing#simple-build-example
" # default cloudbuild has HOME=/builder/home and docker buildx is in /root/.docker/cli-plugins/docker-buildx
# set the home to /root explicitly to if using docker buildx
# - HOME=/root"
| @@ -2,18 +2,26 @@ timeout: 1200s | |||
| steps: | |||
| - name: gcr.io/cloud-builders/docker | |||
| args: | |||
| - HOME=/root | |||
| - buildx | |||
There was a problem hiding this comment.
tried to make command look like https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/.github/workflows/container-image.yaml#L25
wongma7
force-pushed
the
cloudbuildbuildx
branch
from
8407ac9 to
99c4c0a
Compare
| @@ -2,18 +2,26 @@ timeout: 1200s | |||
| steps: | |||
| - name: gcr.io/cloud-builders/docker | |||
| args: | |||
| - buildx | |||
| - build | |||
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
cc #656 |
Pull Request Test Coverage Report for Build 1382
💛 - Coveralls |
Is this a bug fix or adding new feature? fix
What is this PR about? / Why do we need it?
cloudbuild is not magic, if arm64 images are desired then buildx must b ecalled
What testing is done?
command works locally, don't have access to cloudbuild to test it in cloudbuild