-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move chart to charts directory and add workflow to publish new chart versions #624
Conversation
Hi @krmichel. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@leakingtapan This should not be merged until after PR #623 has been merged and the index.yaml is showing as updated in the chart repository at https://kubernetes-sigs.github.io/aws-ebs-csi-driver/index.yaml to show all the available versions or the workflow action won't have the correct version of the index to merge the new version into. |
Pull Request Test Coverage Report for Build 1334
💛 - Coveralls |
@jsafrane @d-nishi @leakingtapan Can I get an okay to test? |
/ok-to-test |
/retest |
@jsafrane @d-nishi @leakingtapan Tests have all passed when you get a chance to look at this. Please look at PR #623 first though. |
@wongma7 Here is the PR I mentioned earlier so you can verify the kube version change |
git config user.name "$GITHUB_ACTOR" | ||
git config user.email "$GITHUB_ACTOR@users.noreply.github.com" | ||
- name: Run chart-releaser | ||
uses: helm/chart-releaser-action@v1.1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool. ref for me https://github.com/helm/chart-releaser-action
/lgtm |
Sorry do you mind rebasing I merged a months old small pr fixing some naming issues. thanks |
@wongma7 I have resolved the conflict |
/lgtm thank you very much for all your contributions to the helm chart!!! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: krmichel, wongma7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@wongma7 it looks like the gh-pages branch is protected and declined the index.yaml update from the action. |
let me check if I can turn off branch protection. https://github.com/kubernetes/test-infra/blob/2abb7ff26579325f6a335990003f665755c96d7a/prow/cmd/branchprotector/README.md#advanced-configuration |
Is this a bug fix or adding new feature?
This is a feature
What is this PR about? / Why do we need it?
Currently managing the index.yaml of the helm chart repository is a manual process and gets out of date quickly. This will move the chart to be a sub-directory of charts which is a pretty standard structure. It also adds a workflow action that will publish a release of the chart and update the index.yaml in the chart repo. The workflow action will also fail if the chart is updated and merged to master without the version being updated (the version of the chart should be increased whenever the chart is modified).
What testing is done?
I tried out the workflow action in my own repo