Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: remove deprecated "beta.kubernetes.io/os" nodeSelector #489

Merged
merged 1 commit into from
Apr 29, 2020
Merged

*: remove deprecated "beta.kubernetes.io/os" nodeSelector #489

merged 1 commit into from
Apr 29, 2020

Conversation

gyuho
Copy link
Member

@gyuho gyuho commented Apr 29, 2020

What is this PR about? / Why do we need it?

https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.16.md

kubelet the beta.kubernetes.io/os and beta.kubernetes.io/arch labels, deprecated since v1.14, are targeted for removal in v1.18.

@gyuho
*: remove deprecated "beta.kubernetes.io/os" nodeSelector
72f9a09 
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 29, 2020
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 29, 2020
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1084

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 78.871%
Totals Coverage Status
Change from base Build 1083: 0.0%
Covered Lines: 1411
Relevant Lines: 1789
💛 - Coveralls

@gyuho
Copy link
Member Author

gyuho commented Apr 29, 2020

/test pull-aws-ebs-csi-driver-verify

@leakingtapan
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 29, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gyuho, leakingtapan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2020
@k8s-ci-robot k8s-ci-robot merged commit 96f02ac into kubernetes-sigs:master Apr 29, 2020
@gyuho gyuho deleted the os-label branch April 29, 2020 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddebroy ddebroy Awaiting requested review from ddebroy

@jsafrane jsafrane Awaiting requested review from jsafrane

Assignees

@leakingtapan leakingtapan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gyuho @coveralls @leakingtapan @k8s-ci-robot