Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade CSI spec to 1.1.0 #263

Merged
merged 1 commit into from
Apr 4, 2019

Conversation

leakingtapan
Copy link
Contributor

/cc @bertinatto

This unblocks volume resizing.

@k8s-ci-robot k8s-ci-robot requested a review from bertinatto April 3, 2019 03:38
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leakingtapan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 3, 2019
@coveralls
Copy link

coveralls commented Apr 3, 2019

Pull Request Test Coverage Report for Build 572

  • 0 of 6 (0.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 65.106%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/driver/controller.go 0 3 0.0%
pkg/driver/node.go 0 3 0.0%
Totals Coverage Status
Change from base Build 571: -0.3%
Covered Lines: 987
Relevant Lines: 1516

💛 - Coveralls

@bertinatto
Copy link
Member

Thanks, @leakingtapan.

Can't merge now because of failing tests, but it's OK if you don't want to fix it because I already imported this in my working branch.

@bertinatto
Copy link
Member

/retest

@leakingtapan
Copy link
Contributor Author

Coverage drop is due to CSI Spec upgrade.

@leakingtapan
Copy link
Contributor Author

The failed test was due to:

�[91m�[1mSummarizing 2 Failures:�[0m

�[91m�[1m[Fail] �[0m�[90m[ebs-csi-e2e] [single-az] Dynamic Provisioning �[0m�[91m�[1m[It] should create a volume on demand with volumeType "sc1" and fsType "ext3" �[0m
�[37m/home/prow/go/src/github.com/kubernetes-sigs/aws-ebs-csi-driver/tests/e2e/testsuites/testsuites.go:313�[0m

�[91m�[1m[Fail] �[0m�[90m[ebs-csi-e2e] [single-az] Dynamic Provisioning �[0m�[91m�[1m[It] should create a volume on demand with volumeType "sc1" and fsType "ext2" �[0m
�[37m/home/prow/go/src/github.com/kubernetes-sigs/aws-ebs-csi-driver/tests/e2e/testsuites/testsuites.go:509�[0m

�[1m�[91mRan 35 of 37 Specs in 1562.276 seconds�[0m
�[1m�[91mFAIL!�[0m -- �[32m�[1m33 Passed�[0m | �[91m�[1m2 Failed�[0m | �[33m�[1m0 Pending�[0m | �[36m�[1m2 Skipped�[0m

It's unrelated to this change. We will revisit all the flaky tests once #192 is done.

@leakingtapan leakingtapan merged commit 960bcab into kubernetes-sigs:master Apr 4, 2019
@leakingtapan leakingtapan deleted the csi-1.1 branch April 4, 2019 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants